45350[!!!][TASK] EXT:form - outsource labels and legends to own partials
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Björn Jacob +1
- Wouter Wolters +1
-
Verified V +2
- Benni Mack +2
- Björn Jacob +1
Issues 1
Files 45
- typo3/sysext/core/Documentation/Changelog/master/Breaking-72310-EXTform-OutsourceLabelsAndLegendsToOwnPartials.rstnew+50 −0
- typo3/sysext/form/Resources/Private/Partials/Default/Confirmation/AdditionalElements/Label.htmlnew+1 −0
- typo3/sysext/form/Resources/Private/Partials/Default/Confirmation/AdditionalElements/Legend.htmlnew+3 −0
- typo3/sysext/form/Resources/Private/Partials/Default/Confirmation/ContainerElements/Checkboxgroup.html+1 −3
- typo3/sysext/form/Resources/Private/Partials/Default/Confirmation/ContainerElements/Fieldset.html+1 −3
- typo3/sysext/form/Resources/Private/Partials/Default/Confirmation/ContainerElements/Radiogroup.html+1 −3
- typo3/sysext/form/Resources/Private/Partials/Default/Confirmation/FlatElements/Checkbox.html+1 −1
- typo3/sysext/form/Resources/Private/Partials/Default/Confirmation/FlatElements/Input.html+1 −1
- typo3/sysext/form/Resources/Private/Partials/Default/Confirmation/FlatElements/Radio.html+1 −1
- typo3/sysext/form/Resources/Private/Partials/Default/Confirmation/FlatElements/Select.html+1 −3
- typo3/sysext/form/Resources/Private/Partials/Default/Confirmation/FlatElements/Textarea.html+1 −1
- typo3/sysext/form/Resources/Private/Partials/Default/Confirmation/FlatElements/Textfield.html+1 −1
- typo3/sysext/form/Resources/Private/Partials/Default/Confirmation/FlatElements/Upload.html+1 −1
- typo3/sysext/form/Resources/Private/Partials/Default/PostProcessor/Mail/Html/AdditionalElements/Label.htmlnew+1 −0
- typo3/sysext/form/Resources/Private/Partials/Default/PostProcessor/Mail/Html/AdditionalElements/Legend.htmlnew+1 −0
- typo3/sysext/form/Resources/Private/Partials/Default/PostProcessor/Mail/Html/ContainerElements/Checkboxgroup.html+1 −1
- typo3/sysext/form/Resources/Private/Partials/Default/PostProcessor/Mail/Html/ContainerElements/Fieldset.html+1 −1
- typo3/sysext/form/Resources/Private/Partials/Default/PostProcessor/Mail/Html/ContainerElements/Radiogroup.html+1 −1
- typo3/sysext/form/Resources/Private/Partials/Default/PostProcessor/Mail/Html/FlatElements/Checkbox.html+1 −1
- typo3/sysext/form/Resources/Private/Partials/Default/PostProcessor/Mail/Html/FlatElements/Input.html+1 −1
Show 25 more files
- typo3/sysext/form/Resources/Private/Partials/Default/PostProcessor/Mail/Html/FlatElements/Radio.html+1 −1
- typo3/sysext/form/Resources/Private/Partials/Default/PostProcessor/Mail/Html/FlatElements/Select.html+1 −1
- typo3/sysext/form/Resources/Private/Partials/Default/PostProcessor/Mail/Html/FlatElements/Textarea.html+1 −1
- typo3/sysext/form/Resources/Private/Partials/Default/PostProcessor/Mail/Html/FlatElements/Textfield.html+1 −1
- typo3/sysext/form/Resources/Private/Partials/Default/PostProcessor/Mail/Html/FlatElements/Upload.html+1 −1
- typo3/sysext/form/Resources/Private/Partials/Default/Show/AdditionalElements/ErrorValidationMessage.htmlnew+3 −0
- typo3/sysext/form/Resources/Private/Partials/Default/Show/AdditionalElements/Label.htmlnew+5 −0
- typo3/sysext/form/Resources/Private/Partials/Default/Show/AdditionalElements/Legend.htmlnew+7 −0
- typo3/sysext/form/Resources/Private/Partials/Default/Show/AdditionalElements/MandatoryValidationMessage.htmlnew+3 −0
- typo3/sysext/form/Resources/Private/Partials/Default/Show/ContainerElements/Checkboxgroup.html+1 −11
- typo3/sysext/form/Resources/Private/Partials/Default/Show/ContainerElements/Radiogroup.html+1 −11
- typo3/sysext/form/Resources/Private/Partials/Default/Show/FlatElements/Button.html+1 −9
- typo3/sysext/form/Resources/Private/Partials/Default/Show/FlatElements/ButtonTag.html+1 −9
- typo3/sysext/form/Resources/Private/Partials/Default/Show/FlatElements/Checkbox.html+1 −9
- typo3/sysext/form/Resources/Private/Partials/Default/Show/FlatElements/Imagebutton.html+1 −9
- typo3/sysext/form/Resources/Private/Partials/Default/Show/FlatElements/Input.html+1 −9
- typo3/sysext/form/Resources/Private/Partials/Default/Show/FlatElements/InputTypeButton.html+1 −9
- typo3/sysext/form/Resources/Private/Partials/Default/Show/FlatElements/Password.html+1 −9
- typo3/sysext/form/Resources/Private/Partials/Default/Show/FlatElements/Radio.html+1 −9
- typo3/sysext/form/Resources/Private/Partials/Default/Show/FlatElements/Reset.html+1 −9
- typo3/sysext/form/Resources/Private/Partials/Default/Show/FlatElements/Select.html+1 −9
- typo3/sysext/form/Resources/Private/Partials/Default/Show/FlatElements/Submit.html+1 −9
- typo3/sysext/form/Resources/Private/Partials/Default/Show/FlatElements/Textarea.html+1 −9
- typo3/sysext/form/Resources/Private/Partials/Default/Show/FlatElements/Textfield.html+1 −9
- typo3/sysext/form/Resources/Private/Partials/Default/Show/FlatElements/Upload.html+1 −9
Review log 23
-
Ralf Zimmermann uploaded patch set 1 12/18/15, 10:49
-
Björn Jacob commented on patch set 2 12/18/15, 12:46
Published edit on patch set 1 -
Björn Jacob commented on patch set 2 CR -1 12/18/15, 13:09
Sweet but one more optimization. Let's move the mandatoryValidationMessages and the validationErrorMessages also to own partials. I.e. introduce new partials within Label and Legend.html. That way integrators are able to easily move the messages around and even have them outside the label etc. -
Ralf Zimmermann uploaded patch set 3 12/18/15, 13:19
-
Björn Jacob commented on patch set 3 CR -1 12/18/15, 14:09
Getting a fatal. Partial for MandatoryValidationMessage and ErrorValidationMessage cannot be found. -
Ralf Zimmermann uploaded patch set 4 12/18/15, 14:25
-
Björn Jacob commented on patch set 4 CR +1 V +1 12/18/15, 14:41
Supplied a test form (see issue). -
Helmut Hummel commented on patch set 4 CR -1 12/18/15, 15:36
imho template structure changes cannot go into a bugfix release -
Helmut Hummel commented on patch set 4 CR 0 01/21/16, 17:37
master is now open again for breaking changes -
Frank Nägler commented on patch set 4 CR -1 01/21/16, 20:07
I am not sure about this patch. Imho partials are not for this kind of use. I have several concerns: 1) possible extensive memory usage 2) a lot of "useless" files 3) different partials for the same task (legend, label) In case of a breaking change this patch need a breaking rst file and must be marked with [!!!] in the commit message. Also I would like to have some more opinions by other core devs. -
Björn Jacob commented on patch set 4 01/21/16, 20:21
Thx Frank for your review. Regarding 1) You're maybe right. That is nothing I can estimate. A benchmark would be needed. If things get really worse by having this kind of separation I would also go for -1. Regarding 2) Which files do you think are useless? EXT:form does provide 3 views (form, confirm, show). Therefore you've got templates for 3 views which results in different templates. A label for example does need to have a label tag in the form view but not in the mail view. The integrator should be able to customize all the views. And it is what EXT:form always allowed the integrator to do. Regarding 3) A label and a legend are not the same. And see 2). We've got 3 views. If there's some potential for having less files then let's try to unlock it. As discussed on Slack I'm fine with providing a .rst. I will add it as soon as we've decided if this is the way to go. I still think this is a good idea since it follows the DRY principle. The integrator is able to change the label, the legend, the error and validation message with a few files. Right now a lot of files have to be touched to change the above mentioned elements since all of them contain the same code. -
Frank Nägler commented on patch set 4 01/21/16, 20:30
I get your arguments, I will re-think about it, give me some hours, I will get you feedback tomorrow. -
Björn Jacob commented on patch set 4 01/21/16, 20:31
Thx again Frank. I'm also on Slack open for discussion. We're having kind of a sprint and Ralf is also available on Slack. Thx! -
Frank Nägler voted on patch set 4 CR 0 01/22/16, 09:49
-
Christian Kuhn commented on patch set 4 CR +1 01/22/16, 09:53
frankie and me talked about it - imho we shouldn't be overly reluctant about partial usage. if there is a major memory problem (i doubt so), this should be fixed in fluid, but shouldn't delay a useful patch here in this client code. let's go for it. -
Frank Nägler commented on patch set 4 01/22/16, 09:58
After talking to some people I am fine with the patch and your idea. please add the rst file and mark the patch as breaking. -
Ralf Zimmermann uploaded patch set 5 01/22/16, 10:52
-
Ralf Zimmermann uploaded patch set 6 01/22/16, 10:53
-
Björn Jacob wrote 01/22/16, 15:28
Patch set 7: Published edit on patch set 6. -
Björn Jacob voted on patch set 7 CR +1 V +1 01/22/16, 15:28
-
Wouter Wolters voted on patch set 7 CR +1 01/29/16, 08:08
-
Benni Mack voted on patch set 7 CR +2 V +2 01/29/16, 09:12
-
Gerrit merged patch set 7 01/29/16, 09:12