Review main Merged

45368[TASK] Create functional test databases with UTF8 character set/collation

Morton Jonuschat CR +2 V +2 Easy +1 −1 updated 01/11/16, 16:33

Commit message

Change the create database statements in the functional test setup to
ensure an UTF-8 character set and collation. Otherwise the tests use the
default collation of the server which could lead to database being
created with Non-UTF-8 character sets like latin1_swedish_ci which is
widely in use as a default character set.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Oliver Klee +1
    • Frank Nägler +1
    • Richard Haeser +1
    • Tymoteusz Motylewski +1
  • Verified V +2
    • Christian Kuhn +2
    • Tymoteusz Motylewski +1

Issues 1

Files 1

Review log 9

  1. Morton Jonuschat uploaded patch set 1 12/18/15, 21:35

  2. Richard Haeser voted on patch set 1 CR +1 12/21/15, 11:03

  3. Tymoteusz Motylewski voted on patch set 1 CR +1 V +1 01/09/16, 10:51

  4. Daniel Goerz voted on patch set 1 CR +1 01/09/16, 22:23

  5. Oliver Klee voted on patch set 1 CR +1 01/10/16, 00:25

  6. Frank Nägler voted on patch set 1 CR +1 01/11/16, 15:12

  7. Christian Kuhn voted on patch set 1 CR +1 V +1 01/11/16, 16:32

  8. Christian Kuhn voted on patch set 1 CR +2 V +2 01/11/16, 16:33

  9. Gerrit merged patch set 1 01/11/16, 16:33