Review main Merged

45374[BUGFIX] Use $this-> instead of $GLOBALS['LANG'] in LanguageService

Benni Mack CR +2 V +2 Easy +1 −1 updated 12/21/15, 11:48

Commit message

The method getLabelsWithPrefix was moved to LanguageService and does not
use $this but currently uses $GLOBALS['LANG'].

This is not necessary and is changed accordingly.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Michael Oehlhof +1
  • Verified V +2
    • Wouter Wolters +2
    • Michael Oehlhof +1

Issues 1

Files 1

Review log 7

  1. Benni Mack uploaded patch set 1 12/19/15, 20:43

  2. Benni Mack commented on patch set 2 12/19/15, 20:44

    Published edit on patch set 1
  3. Benni Mack wrote 12/19/15, 20:45

    Topic set to Language
  4. Michael Oehlhof voted on patch set 2 CR +1 V +1 12/19/15, 21:57

  5. Wouter Wolters voted on patch set 2 CR +1 12/20/15, 18:56

  6. Wouter Wolters voted on patch set 2 CR +2 V +2 12/21/15, 11:48

  7. Gerrit merged patch set 2 12/21/15, 11:48