Review main Merged

45375[TASK] Instantiate csConv directly instead of accessing the parent class

Benni Mack CR +2 V +2 Easy +7 −33 updated 12/23/15, 13:21

Commit message

There are several places in the core which checks
if CharsetConverter is available already, but since
the CharsetConverter is not related to the context,
the code can be simplified.

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Michael Oehlhof +1
    • Thomas Schlumberger +1
  • Verified V +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Thomas Schlumberger +1

Issues 1

Files 3

Review log 7

  1. Benni Mack uploaded patch set 1 12/19/15, 20:43

  2. Benni Mack wrote 12/19/15, 20:45

    Topic set to Language
  3. Michael Oehlhof voted on patch set 1 CR +1 12/19/15, 22:06

  4. Wouter Wolters voted on patch set 1 CR +1 V +1 12/21/15, 22:25

  5. Thomas Schlumberger voted on patch set 1 CR +1 V +1 12/23/15, 12:38

  6. Benni Mack voted on patch set 1 CR +2 V +2 12/23/15, 13:21

  7. Gerrit merged patch set 1 12/23/15, 13:21