Review main Merged Breaking

45376[!!!][TASK] Remove GraphicalFunctions->nativeCharset

Benni Mack CR +2 V +2 Normal +42 −69 updated 12/30/15, 17:48

Commit message

GraphicalFunctions contains an option called
"nativeCharset" which is set to utf8 at all times,
changing encoding functionality to use csConv.

This can be simplified by always using csConv.

The functions "singleChars" and "recodeString" are then
obsolete and completely removed, as well as the
functionality to set "nativeCharset" to something else than utf-8.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
    • Andreas Kienast +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 3

Review log 10

  1. Benni Mack uploaded patch set 1 12/19/15, 20:43

  2. Benni Mack wrote 12/19/15, 20:45

    Topic set to Language
  3. Benni Mack uploaded patch set 2 12/30/15, 14:08

  4. Andreas Kienast commented on patch set 2 CR -1 12/30/15, 14:11

    ReST document is missing
  5. Markus Klein commented on patch set 2 12/30/15, 14:32

    Looks good, rst tbd
  6. Benni Mack uploaded patch set 3 12/30/15, 14:33

  7. Markus Klein voted on patch set 3 CR +1 V +1 12/30/15, 14:40

  8. Andreas Kienast voted on patch set 3 CR +1 12/30/15, 14:40

  9. Wouter Wolters voted on patch set 3 CR +2 V +2 12/30/15, 17:48

  10. Gerrit merged patch set 3 12/30/15, 17:48