Review main Merged

45377[TASK] Make CharsetConverter (csConv) a singleton

Benni Mack CR +2 V +2 Easy +2 −1 updated 12/21/15, 18:32

Commit message

The CharsetConverter is agnostic to the surroundings,
so it can be simply be instantiated once with a Singleton
at any time.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Georg Ringer +1
    • Michael Oehlhof +1
  • Verified V +2
    • Andreas Kienast +2
    • Georg Ringer +1

Issues 1

Files 1

Review log 6

  1. Benni Mack uploaded patch set 1 12/19/15, 20:43

  2. Benni Mack wrote 12/19/15, 20:45

    Topic set to Language
  3. Michael Oehlhof voted on patch set 1 CR +1 12/19/15, 22:09

  4. Georg Ringer voted on patch set 1 CR +1 V +1 12/21/15, 18:18

  5. Andreas Kienast voted on patch set 1 CR +2 V +2 12/21/15, 18:32

  6. Gerrit merged patch set 1 12/21/15, 18:32