Review main Merged

45398[TASK] Deprecate LanguageService->makeEntities

Benni Mack CR +2 V +2 Easy +34 −10 updated 12/22/15, 06:56

Commit message

This method ``LanguageService->makeEntities()`` was used when the TYPO3
Backend ran with non-utf8 characters in order to convert UTF-8
characters to latin1. This is not needed anymore as all is UTF-8 now.

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Michael Oehlhof +1
  • Verified V +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Michael Oehlhof +1

Issues 1

Files 4

Review log 9

  1. Benni Mack uploaded patch set 1 12/21/15, 16:43

  2. Andreas Kienast commented on patch set 2 12/21/15, 16:46

    Published edit on patch set 1
  3. Georg Ringer voted on patch set 2 CR +1 V +1 12/21/15, 18:15

  4. Wouter Wolters commented on patch set 2 CR -1 12/21/15, 20:57

    Deprecation-71916-LanguageService-makeEntities.rst:16

    we deprecate it first. no fatal error will happen.
  5. Wouter Wolters commented on patch set 3 12/21/15, 22:26

    Published edit on patch set 2
  6. Wouter Wolters voted on patch set 3 CR +1 V +1 12/21/15, 22:28

  7. Michael Oehlhof voted on patch set 3 CR +1 V +1 12/21/15, 23:49

  8. Benni Mack voted on patch set 3 CR +2 V +2 12/22/15, 06:56

  9. Gerrit merged patch set 3 12/22/15, 06:56