Review main Merged

45404[BUGFIX] Send correct HTTP message in getUrl

Markus Klein CR +2 V +2 Easy +4 −5 updated 12/23/15, 12:22

Commit message

Review

  • Code review CR +2
    • Frank Nägler +2
    • Daniel Goerz +1
    • D. Röhrig +1
  • Verified V +2
    • Frank Nägler +2
    • D. Röhrig +1

Issues 1

Files 1

Review log 13

  1. Markus Klein uploaded patch set 1 12/22/15, 10:23

  2. Andreas Kienast voted on patch set 1 CR +1 12/22/15, 10:34

  3. D. Röhrig commented on patch set 2 12/22/15, 10:59

    Published edit on patch set 1
  4. D. Röhrig commented on patch set 2 12/22/15, 11:03

    I had some problems with the correct amount of CRLFs. With this patch it works fine, but I don't know, if the following $requestHeaders can be recognized in request.
  5. Markus Klein commented on patch set 2 CR -1 12/22/15, 11:10

    a HTTP message MUST end with two CRLF. So set 1 should be correct as it adds the last CRLF at the very end and attaches the request headers on demand correctly.
  6. Markus Klein rebased onto patch set 2 12/22/15, 11:10

  7. Markus Klein uploaded patch set 4 12/22/15, 11:12

  8. D. Röhrig voted on patch set 4 CR +1 V +1 12/22/15, 12:01

  9. Daniel Goerz voted on patch set 4 CR +1 12/23/15, 11:42

  10. Frank Nägler voted on patch set 4 CR +1 12/23/15, 12:15

  11. Frank Nägler voted on patch set 4 CR +2 V +2 12/23/15, 12:21

  12. Gerrit merged patch set 4 12/23/15, 12:21

  13. Frank Nägler commented on patch set 5 12/23/15, 12:22

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit c9f80adb32447e8df236c8dcb4a2a9de7cd8293c