45407[BUGFIX] Avoid duplicated code in parse_typoscript/tokenizetyposcript.js
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Alexander Opitz +1
- Andreas Kienast +1
-
Verified V +2
- Frank Nägler +2
- Alexander Opitz +1
- Andreas Kienast +1
Issues 1
Files 1
Review log 18
-
Alexander Opitz uploaded patch set 1 12/22/15, 13:50
-
Wouter Wolters commented on patch set 2 12/22/15, 14:01
Published edit on patch set 1 -
Alexander Opitz uploaded patch set 3 12/22/15, 15:08
-
Alexander Opitz updated the commit message in patch set 4 12/22/15, 15:09
-
Daniel Goerz commented on patch set 5 12/23/15, 19:03
Published edit on patch set 4 -
Daniel Goerz commented on patch set 5 12/23/15, 19:04
7.6 as well? -
Andreas Kienast commented on patch set 5 CR -1 12/23/15, 19:12
tokenizetyposcript.js:42This is doubled now, but which of both is correct?tokenizetyposcript.js:113This is doubled now, but which of both is correct?tokenizetyposcript.js:204This is doubled now, but which of both is correct?tokenizetyposcript.js:207This is doubled now, but which of both is correct?tokenizetyposcript.js:356This is doubled now, but which of both is correct?tokenizetyposcript.js:527This is doubled now, but which of both is correct?tokenizetyposcript.js:560This is doubled now, but which of both is correct?tokenizetyposcript.js:562This is doubled now, but which of both is correct?tokenizetyposcript.js:633This is doubled now, but which of both is correct?tokenizetyposcript.js:712This is doubled now, but which of both is correct?tokenizetyposcript.js:886This is doubled now, but which of both is correct?tokenizetyposcript.js:905This is doubled now, but which of both is correct?tokenizetyposcript.js:951This is doubled now, but which of both is correct?tokenizetyposcript.js:993This is doubled now, but which of both is correct?tokenizetyposcript.js:1038This is doubled now, but which of both is correct?tokenizetyposcript.js:1047This is doubled now, but which of both is correct?tokenizetyposcript.js:1089}; -
Alexander Opitz uploaded patch set 6 01/04/16, 09:56
-
Alexander Opitz commented on patch set 6 01/04/16, 10:00
* Don't like to backport such hard changes. It is straight but can it break? And 8 LTS will be faster then 7 LTS. ;) * Fixed all 17 comments. -
Marius Wieschollek commented on patch set 6 CR -1 03/05/16, 22:18
tokenizetyposcript.js:967Is this a spelling mistake? -
Andreas Kienast commented on patch set 6 03/11/16, 07:43
tokenizetyposcript.js:967ReplyLooks like this typo is there for ages. -
Andreas Kienast uploaded patch set 7 03/11/16, 08:00
-
Andreas Kienast commented on patch set 7 03/11/16, 08:01
Rebased and fixed typo of "tabel" -
Alexander Opitz voted on patch set 7 CR +1 V +1 03/15/16, 11:30
-
Frank Nägler voted on patch set 7 CR +1 03/16/16, 17:01
-
Andreas Kienast voted on patch set 7 CR +1 V +1 03/16/16, 18:58
-
Frank Nägler voted on patch set 7 CR +2 V +2 03/16/16, 18:59
-
Gerrit merged patch set 7 03/16/16, 18:59