Review main Merged

45407[BUGFIX] Avoid duplicated code in parse_typoscript/tokenizetyposcript.js

Alexander Opitz CR +2 V +2 Expert +255 −1580 updated 03/16/16, 18:59

Commit message

The doubled wordlists got merged|sorted|uniqed. The JS source is
taken from the lower, as it got a fix lately and should also be
the one which runs inside browsers.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Alexander Opitz +1
    • Andreas Kienast +1
  • Verified V +2
    • Frank Nägler +2
    • Alexander Opitz +1
    • Andreas Kienast +1

Issues 1

Files 1

Review log 18

  1. Alexander Opitz uploaded patch set 1 12/22/15, 13:50

  2. Wouter Wolters commented on patch set 2 12/22/15, 14:01

    Published edit on patch set 1
  3. Alexander Opitz uploaded patch set 3 12/22/15, 15:08

  4. Alexander Opitz updated the commit message in patch set 4 12/22/15, 15:09

  5. Daniel Goerz commented on patch set 5 12/23/15, 19:03

    Published edit on patch set 4
  6. Daniel Goerz commented on patch set 5 12/23/15, 19:04

    7.6 as well?
  7. Andreas Kienast commented on patch set 5 CR -1 12/23/15, 19:12

    tokenizetyposcript.js:42

    This is doubled now, but which of both is correct?

    tokenizetyposcript.js:113

    This is doubled now, but which of both is correct?

    tokenizetyposcript.js:204

    This is doubled now, but which of both is correct?

    tokenizetyposcript.js:207

    This is doubled now, but which of both is correct?

    tokenizetyposcript.js:356

    This is doubled now, but which of both is correct?

    tokenizetyposcript.js:527

    This is doubled now, but which of both is correct?

    tokenizetyposcript.js:560

    This is doubled now, but which of both is correct?

    tokenizetyposcript.js:562

    This is doubled now, but which of both is correct?

    tokenizetyposcript.js:633

    This is doubled now, but which of both is correct?

    tokenizetyposcript.js:712

    This is doubled now, but which of both is correct?

    tokenizetyposcript.js:886

    This is doubled now, but which of both is correct?

    tokenizetyposcript.js:905

    This is doubled now, but which of both is correct?

    tokenizetyposcript.js:951

    This is doubled now, but which of both is correct?

    tokenizetyposcript.js:993

    This is doubled now, but which of both is correct?

    tokenizetyposcript.js:1038

    This is doubled now, but which of both is correct?

    tokenizetyposcript.js:1047

    This is doubled now, but which of both is correct?

    tokenizetyposcript.js:1089

    };
  8. Alexander Opitz uploaded patch set 6 01/04/16, 09:56

  9. Alexander Opitz commented on patch set 6 01/04/16, 10:00

    * Don't like to backport such hard changes. It is straight but can it break? And 8 LTS will be faster then 7 LTS. ;) * Fixed all 17 comments.
  10. Marius Wieschollek commented on patch set 6 CR -1 03/05/16, 22:18

    tokenizetyposcript.js:967

    Is this a spelling mistake?
  11. Andreas Kienast commented on patch set 6 03/11/16, 07:43

    tokenizetyposcript.js:967 Reply

    Looks like this typo is there for ages.
  12. Andreas Kienast uploaded patch set 7 03/11/16, 08:00

  13. Andreas Kienast commented on patch set 7 03/11/16, 08:01

    Rebased and fixed typo of "tabel"
  14. Alexander Opitz voted on patch set 7 CR +1 V +1 03/15/16, 11:30

  15. Frank Nägler voted on patch set 7 CR +1 03/16/16, 17:01

  16. Andreas Kienast voted on patch set 7 CR +1 V +1 03/16/16, 18:58

  17. Frank Nägler voted on patch set 7 CR +2 V +2 03/16/16, 18:59

  18. Gerrit merged patch set 7 03/16/16, 18:59