45410[BUGFIX] EXT:form - Fix CHECKBOXGROUP and RADIOGROUP in form wizard
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Björn Jacob +1
- Eugen Lang +1
- Florian Mast +1
-
Verified V +2
- Christian Kuhn +2
- Björn Jacob +1
- Gianluigi Martino +1
- Florian Mast +1
Issues 1
Files 5
- typo3/sysext/form/Classes/Domain/Model/Json/CheckboxGroupJsonElement.php+5 −1
- typo3/sysext/form/Classes/Domain/Model/Json/RadioGroupJsonElement.php+5 −1
- typo3/sysext/form/Resources/Public/JavaScript/Wizard/Elements/Predefined/CheckboxGroup.js+18 −7
- typo3/sysext/form/Resources/Public/JavaScript/Wizard/Elements/Predefined/RadioGroup.js+18 −7
- typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Options.js1+18 −2
Review log 18
-
Andreas Häfner uploaded patch set 1 12/22/15, 16:31
-
Björn Jacob commented on patch set 2 12/23/15, 06:23
Published edit on patch set 1 -
Björn Jacob commented on patch set 2 CR -1 12/23/15, 06:29
Could you pls fix the comment?Options.js:234I think this comment is not the correct one/ describes the function correctly. -
Andreas Häfner uploaded patch set 3 12/23/15, 13:24
-
Björn Jacob wrote 01/21/16, 14:45
Patch set 4: Commit message was updated. -
Björn Jacob voted on patch set 4 CR +1 V +1 01/21/16, 14:45
-
Björn Jacob wrote 01/21/16, 14:46
Patch set 5: Commit message was updated. -
Björn Jacob voted on patch set 5 CR +1 V +1 01/21/16, 14:46
-
Gianluigi Martino commented on patch set 5 V -1 01/21/16, 15:15
for the first group it works, if i will add a second group i have the same js error as before -
Gianluigi Martino commented on patch set 5 V 0 01/21/16, 15:24
seems to be a problem with my installation -
Gianluigi Martino voted on patch set 5 V +1 01/21/16, 15:30
-
Florian Mast voted on patch set 5 V -1 03/03/16, 14:21
-
Florian Mast voted on patch set 5 V +1 03/03/16, 14:22
-
Florian Mast voted on patch set 5 CR +1 03/03/16, 14:43
-
Eugen Lang voted on patch set 5 CR +1 03/04/16, 15:04
-
Christian Kuhn voted on patch set 5 CR +2 V +2 03/04/16, 16:02
-
Gerrit merged patch set 5 03/04/16, 16:02
-
Christian Kuhn commented on patch set 6 03/04/16, 16:02
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 27264397e9f60a3b29a4cc4517a55f6155bfd16d