Review main Merged

45410[BUGFIX] EXT:form - Fix CHECKBOXGROUP and RADIOGROUP in form wizard

Andreas Häfner CR +2 V +2 Normal +64 −18 updated 03/04/16, 16:02

Commit message

Fixes a JS error, which appeared when adding a CHECKBOXGROUP or
RADIOGROUP within the form wizard.

Furthermore it applies "text" instead of "data" which was already
changed for TEXTAREA and OPTION elements (as discussed in #69369).

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Björn Jacob +1
    • Eugen Lang +1
    • Florian Mast +1
  • Verified V +2
    • Christian Kuhn +2
    • Björn Jacob +1
    • Gianluigi Martino +1
    • Florian Mast +1

Issues 1

Files 5

Review log 18

  1. Andreas Häfner uploaded patch set 1 12/22/15, 16:31

  2. Björn Jacob commented on patch set 2 12/23/15, 06:23

    Published edit on patch set 1
  3. Björn Jacob commented on patch set 2 CR -1 12/23/15, 06:29

    Could you pls fix the comment?

    Options.js:234

    I think this comment is not the correct one/ describes the function correctly.
  4. Andreas Häfner uploaded patch set 3 12/23/15, 13:24

  5. Björn Jacob wrote 01/21/16, 14:45

    Patch set 4: Commit message was updated.
  6. Björn Jacob voted on patch set 4 CR +1 V +1 01/21/16, 14:45

  7. Björn Jacob wrote 01/21/16, 14:46

    Patch set 5: Commit message was updated.
  8. Björn Jacob voted on patch set 5 CR +1 V +1 01/21/16, 14:46

  9. Gianluigi Martino commented on patch set 5 V -1 01/21/16, 15:15

    for the first group it works, if i will add a second group i have the same js error as before
  10. Gianluigi Martino commented on patch set 5 V 0 01/21/16, 15:24

    seems to be a problem with my installation
  11. Gianluigi Martino voted on patch set 5 V +1 01/21/16, 15:30

  12. Florian Mast voted on patch set 5 V -1 03/03/16, 14:21

  13. Florian Mast voted on patch set 5 V +1 03/03/16, 14:22

  14. Florian Mast voted on patch set 5 CR +1 03/03/16, 14:43

  15. Eugen Lang voted on patch set 5 CR +1 03/04/16, 15:04

  16. Christian Kuhn voted on patch set 5 CR +2 V +2 03/04/16, 16:02

  17. Gerrit merged patch set 5 03/04/16, 16:02

  18. Christian Kuhn commented on patch set 6 03/04/16, 16:02

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 27264397e9f60a3b29a4cc4517a55f6155bfd16d