Review main Merged

45421[BUGFIX] Handle empty pid list in FrontendConfigurationManager

Markus Klein CR +2 V +2 Easy +14 −8 updated 12/23/15, 20:32

Commit message

The result of getTreeList() called in overrideStoragePidIfStartingPointIsSet()
may be an empty string, which is appended to the $list array.
Empty values should not be added to the array, since it will cause an invalid
list of pages later on.

Add a check to avoid empty values in $list.

Review

  • Code review CR +2
    • Benni Mack +2
    • Daniel Goerz +1
  • Verified V +2
    • Benni Mack +2
    • Daniel Goerz +1

Issues 1

Files 1

Review log 6

  1. Markus Klein uploaded patch set 1 12/23/15, 12:46

  2. Daniel Goerz voted on patch set 1 CR +1 V +1 12/23/15, 18:48

  3. Benni Mack voted on patch set 1 CR +2 V +2 12/23/15, 20:25

  4. Gerrit merged patch set 1 12/23/15, 20:25

  5. Benni Mack commented on patch set 2 12/23/15, 20:26

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit d775530fb639ba7222714191bfc00f79fe7d4ce4
  6. Philipp Gampe commented on patch set 1 12/23/15, 20:32

    IMHO missing unit test