45482[TASK] Expose identifier and path of functional test instance
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
- Morton Jonuschat +1
-
Verified V +2
- Oliver Hader +2
- Morton Jonuschat +1
Issues 1
Files 2
Review log 10
-
Oliver Hader uploaded patch set 1 12/28/15, 16:19
-
Georg Ringer commented on patch set 2 12/28/15, 18:32
Published edit on patch set 1 -
Georg Ringer voted on patch set 2 CR +1 V +1 12/28/15, 18:32
-
Artus Kolanowski commented on patch set 2 CR +1 V +1 12/28/15, 19:01
The only thing I've questioned myself was, why would we need the private member `FunctionalTestCase::$instancePath` any more? The only place it's used is in `FunctionalTestCase::getFrontendResponse()`. -
Oliver Hader uploaded patch set 3 12/29/15, 10:37
-
Oliver Hader commented on patch set 3 12/29/15, 10:49
Removed the private $instancePath. Travis: https://travis-ci.org/ohader/TYPO3.CMS/builds/99236911 -
Morton Jonuschat voted on patch set 3 CR +1 12/29/15, 18:13
-
Morton Jonuschat voted on patch set 3 V +1 12/29/15, 18:18
-
Oliver Hader commented on patch set 3 CR +2 V +2 12/29/15, 18:41
Thx for the reviews -
Gerrit merged patch set 3 12/29/15, 18:41