Review main Merged

45482[TASK] Expose identifier and path of functional test instance

Oliver Hader CR +2 V +2 Normal +51 −10 updated 12/29/15, 18:41

Commit message

Identifier and path of a functional test instance is created during
bootstrapping the testcase. However, if one needs to define particular
path settings to the initialization phase, this will end up in being
a chicken-or-the-egg problem.

That's why the mentioned two parts are exposed as static functions
and wrapped by the functional test base class.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Morton Jonuschat +1
  • Verified V +2
    • Oliver Hader +2
    • Morton Jonuschat +1

Issues 1

Files 2

Review log 10

  1. Oliver Hader uploaded patch set 1 12/28/15, 16:19

  2. Georg Ringer commented on patch set 2 12/28/15, 18:32

    Published edit on patch set 1
  3. Georg Ringer voted on patch set 2 CR +1 V +1 12/28/15, 18:32

  4. Artus Kolanowski commented on patch set 2 CR +1 V +1 12/28/15, 19:01

    The only thing I've questioned myself was, why would we need the private member `FunctionalTestCase::$instancePath` any more? The only place it's used is in `FunctionalTestCase::getFrontendResponse()`.
  5. Oliver Hader uploaded patch set 3 12/29/15, 10:37

  6. Oliver Hader commented on patch set 3 12/29/15, 10:49

    Removed the private $instancePath. Travis: https://travis-ci.org/ohader/TYPO3.CMS/builds/99236911
  7. Morton Jonuschat voted on patch set 3 CR +1 12/29/15, 18:13

  8. Morton Jonuschat voted on patch set 3 V +1 12/29/15, 18:18

  9. Oliver Hader commented on patch set 3 CR +2 V +2 12/29/15, 18:41

    Thx for the reviews
  10. Gerrit merged patch set 3 12/29/15, 18:41