Review main Merged

45505[TASK] Move non-public files to typo3temp/var/

Benni Mack CR +2 V +2 Normal +81 −52 updated 01/12/16, 08:46

Commit message

Add a subdirectory typo3temp/var/ (by default) which
contains all files which should never be accessible
for the web user.

In the future, this option should be configurable so it can
be put outside of the document root (e.g. via an
environment variable).

Review

  • Code review CR +2
    • Susi Moog +2
    • Mathias Schreiber +1
  • Verified V +2
    • Susi Moog +2
    • Mathias Schreiber +1

Issues 1

Files 21

Review log 16

  1. Benni Mack uploaded patch set 1 12/30/15, 13:35

  2. Morton Jonuschat voted on patch set 1 CR +1 12/30/15, 13:42

  3. Benni Mack uploaded patch set 2 12/30/15, 14:32

  4. Stefan Froemken commented on patch set 2 01/04/16, 07:43

    What about the temporaryDirectory of rsaauth? I think it would be good to have it in that new directory, too. Maybe we can also remove that extension configuration.
  5. Benni Mack uploaded patch set 3 01/04/16, 21:01

  6. Benni Mack uploaded patch set 4 01/09/16, 07:06

  7. Benni Mack uploaded patch set 5 01/09/16, 07:10

  8. Benni Mack uploaded patch set 6 01/09/16, 07:18

  9. Tymoteusz Motylewski commented on patch set 6 CR -1 01/09/16, 09:51

    DocumentationService.php:41

    is omitting "Documentation" path part done on purpose? Shouldn't it be var/transient/Documentation/documents.json ?

    UpdateScriptUtility.php:111

    same here

    TerService.php:135

    same here
  10. Benni Mack commented on patch set 6 01/10/16, 12:04

    DocumentationService.php:41 Reply

    yes. these files are basically moved to other places or just for documentations, but are not necessary for the time being. Especially the other files below are only there at the time of only one request (unzipped to typo3conf/Documentation). I also don't think it makes sense to only have typo3temp/var/transient/Documentation/ for just one file, agree?

    UpdateScriptUtility.php:111 Reply

    these temporary files are there for executing an udpate script of an extension and are regenerated if necessary, so I think the transient (= dump, can be deleted any time as these files are really not necessary for the rest of the system run.
  11. Mathias Schreiber voted on patch set 6 CR +1 V +1 01/11/16, 08:58

  12. Tymoteusz Motylewski commented on patch set 6 CR 0 01/11/16, 11:08

    ok, then I'm removing my -1. I just wanted to be sure that we will not end up in the debugging hell with thousands of files in one folder.
  13. Susi Moog voted on patch set 6 V +1 01/11/16, 12:54

  14. Susi Moog voted on patch set 6 CR +1 01/12/16, 08:45

  15. Susi Moog voted on patch set 6 CR +2 V +2 01/12/16, 08:45

  16. Gerrit merged patch set 6 01/12/16, 08:46