Review main Merged

45535[TASK] Code cleanup FormEngine.js

Andreas Kienast CR +2 V +2 Normal +46 −53 updated 01/08/16, 16:16

Commit message

The code of FormEngine.js is a bit cleaned up:
- Initialize variables explicitly
- Fix a typo: "undefinied" > "undefined"
- Chain event listeners

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Wouter Wolters +1
    • Michael Oehlhof +1
  • Verified V +2
    • Morton Jonuschat +2
    • Michael Oehlhof +1

Issues 1

Files 1

Review log 8

  1. Andreas Kienast uploaded patch set 1 12/31/15, 17:26

  2. Michael Oehlhof commented on patch set 1 CR +1 V +1 12/31/15, 17:42

    My last review in 2015
  3. Morton Jonuschat wrote 12/31/15, 17:54

    Patch set 2: Published edit on patch set 1.
  4. Morton Jonuschat voted on patch set 2 CR +1 12/31/15, 17:55

  5. Michael Oehlhof voted on patch set 2 CR +1 V +1 01/03/16, 10:31

  6. Wouter Wolters voted on patch set 2 CR +1 01/07/16, 21:55

  7. Morton Jonuschat voted on patch set 2 CR +2 V +2 01/08/16, 16:16

  8. Gerrit merged patch set 2 01/08/16, 16:16