Review main Merged

45536[BUGFIX] Load icons for localization wizard properly

Andreas Kienast CR +2 V +2 Easy +6 −7 updated 01/07/16, 21:52

Commit message

Due to the current API implementation multiple icons can't be loaded
in a single $.when() call. This causes issues after the icons are cached
as the return value of the promise changes.

The icons are fetched one by one in nested calls to workaround the issue.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Daniel Goerz +1
  • Verified V +2
    • Wouter Wolters +2
    • Daniel Goerz +1
    • Gianluigi Martino +1
    • Stefan Froemken +1

Issues 1

Files 1

Review log 7

  1. Andreas Kienast uploaded patch set 1 12/31/15, 17:49

  2. Daniel Goerz voted on patch set 1 CR +1 V +1 01/03/16, 13:36

  3. Stefan Froemken voted on patch set 1 V +1 01/04/16, 07:32

  4. Gianluigi Martino voted on patch set 1 V +1 01/04/16, 19:38

  5. Wouter Wolters voted on patch set 1 CR +2 V +2 01/07/16, 21:52

  6. Gerrit merged patch set 1 01/07/16, 21:52

  7. Wouter Wolters commented on patch set 2 01/07/16, 21:52

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 04b91a002e8b16f94a8711b9b8564d28c04e3744