Review main Merged

45547[TASK] Use constants for checking CharsetConverter

Benni Mack CR +2 V +2 Easy +37 −11 updated 01/07/16, 11:34

Commit message

The inner parts of CharsetConverter are checking for
the TYPO3_CONF_VARS setting. This is now cleaned up
by using a protected method return constants.

This is a pre-step towards migrating the current options.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
  • Verified V +2
    • Georg Ringer +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 10

  1. Benni Mack uploaded patch set 1 01/01/16, 20:54

  2. Daniel Goerz commented on patch set 1 CR -1 01/03/16, 13:33

    CharsetConverter.php:1549

    This was mbstring before
  3. Benni Mack wrote 01/03/16, 14:55

    Patch set 2: Published edit on patch set 1.
  4. Daniel Goerz voted on patch set 2 CR +1 01/03/16, 15:14

  5. Georg Ringer voted on patch set 2 CR +1 V +1 01/03/16, 17:52

  6. Wouter Wolters commented on patch set 2 01/07/16, 09:56

    CharsetConverter.php:2287

    elseif
  7. Wouter Wolters wrote 01/07/16, 10:36

    Patch set 3: Published edit on patch set 2.
  8. Wouter Wolters voted on patch set 3 CR +1 V +1 01/07/16, 10:36

  9. Georg Ringer voted on patch set 3 CR +2 V +2 01/07/16, 11:34

  10. Gerrit merged patch set 3 01/07/16, 11:34