Review main Merged

45568[TASK] Remove hard coded extension paths

Helmut Hummel CR +2 V +2 Normal +96 −73 updated 01/09/16, 06:08

Commit message

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Markus Klein +1
  • Verified V +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Markus Klein +1

Issues 1

Files 20

Review log 21

  1. Helmut Hummel uploaded patch set 1 01/04/16, 14:11

  2. Helmut Hummel commented on patch set 1 CR -2 V -1 01/04/16, 14:12

    still WIP
  3. Helmut Hummel uploaded patch set 2 01/04/16, 14:27

  4. Helmut Hummel voted on patch set 2 CR 0 01/04/16, 14:28

  5. Andreas Kienast uploaded patch set 3 01/04/16, 14:43

  6. Andreas Kienast voted on patch set 3 CR +1 01/04/16, 14:48

  7. Benni Mack commented on patch set 3 01/04/16, 15:06

    Awesome. I think we should do that for 7.6 as well, what do you think?
  8. Helmut Hummel commented on patch set 3 01/04/16, 15:07

    > Awesome. Thanks :) I think we should do that for 7.6 as well, what do you think? If we take extra care to not introduce a bug with this one, I'm fine if this goes into 7.6
  9. Nicole Hummel voted on patch set 3 CR +1 01/04/16, 15:33

  10. Benni Mack wrote 01/04/16, 21:05

    Patch set 4: Commit message was updated.
  11. Benni Mack commented on patch set 4 01/04/16, 21:06

    I think special extra-heavy testing needs to go in FE Editing / Admin Panel, and workspaces. but of course the other parts need to be tested as well.
  12. Benni Mack voted on patch set 4 CR +1 V +1 01/08/16, 15:18

  13. Wouter Wolters voted on patch set 4 CR +1 V +1 01/08/16, 19:11

  14. Markus Klein commented on patch set 4 01/08/16, 19:39

    PageRenderer.php:457

    reset() is called multiple times, so this won't work then.

    ContentObjectRenderer.php:4171

    ::extPath('core')
  15. Markus Klein commented on patch set 4 CR -1 V -1 01/08/16, 19:47

    debugged that now. it fails!
  16. Markus Klein uploaded patch set 5 01/08/16, 19:50

  17. Markus Klein voted on patch set 5 CR +1 V +1 01/08/16, 19:50

  18. Wouter Wolters voted on patch set 5 CR +1 V +1 01/08/16, 19:54

  19. Benni Mack voted on patch set 5 CR +2 V +2 01/09/16, 06:08

  20. Gerrit merged patch set 5 01/09/16, 06:08

  21. Benni Mack commented on patch set 6 01/09/16, 06:08

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit b4bd2774b36a984e7670f32e4276f4d96be68d9b