45581[FEATURE] Introduce native support for Symfony Console
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Morton Jonuschat +1
-
Verified V +2
- Georg Ringer +2
- Morton Jonuschat +1
Issues 1
Files 11
- typo3/sysext/backend/Classes/Command/LockBackendCommand.php1new+117 −0
- typo3/sysext/backend/Configuration/Commands.phpnew+16 −0
- typo3/sysext/core/bin/t3consolenew+23 −0
- typo3/sysext/core/Classes/Console/CommandApplication.php2new+103 −0
- typo3/sysext/core/Classes/Console/CommandRequestHandler.phpnew+181 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-73042-IntroduceNativeSupportForSymfonyConsole.rstnew+49 −0
- typo3/sysext/core/composer.json+3 −0
- typo3/sysext/lowlevel/Classes/AdminCommand.phpdeleted+0 −105
- typo3/sysext/lowlevel/ext_localconf.php+0 −7
- composer.json+3 −0
- composer.lock+1 −1
Review log 16
-
Benni Mack uploaded patch set 1 01/04/16, 20:38
-
Benni Mack commented on patch set 1 CR -1 01/04/16, 20:39
WIP -
Benni Mack uploaded patch set 2 01/04/16, 21:29
-
Wouter Wolters commented on patch set 2 01/04/16, 22:34
CommandApplication.php:148missing @paramCommandApplication.php:176getter for the global be-user? -
Benni Mack uploaded patch set 3 01/30/16, 22:59
-
Benni Mack wrote 01/30/16, 23:12
Patch set 4: Published edit on patch set 3. -
Mathias Brodala commented on patch set 3 01/30/16, 23:15
LockBackendCommand.php:57This style of command handling can get tedious given enough commands on the same class. Maybe the API could be changed a little to map commands to methods? These methods could receive I/O objects just like now. -
Benni Mack uploaded patch set 5 01/30/16, 23:31
-
Benni Mack commented on patch set 5 01/30/16, 23:33
@mbrodala: yes, could be done. We could even split the class in two Commands. For this small example I chose to do it with this simple check in order to keep the overview. I'm fine with either way. -
Georg Ringer uploaded patch set 6 01/31/16, 20:14
-
Georg Ringer voted on patch set 6 CR +1 V +1 01/31/16, 21:03
-
Morton Jonuschat uploaded patch set 7 02/01/16, 06:29
-
Morton Jonuschat voted on patch set 7 CR +1 V +1 02/01/16, 06:30
-
Georg Ringer voted on patch set 7 CR +1 V +1 02/01/16, 07:00
-
Georg Ringer voted on patch set 7 CR +2 V +2 02/01/16, 09:22
-
Gerrit merged patch set 7 02/01/16, 09:22