Review main Merged

45581[FEATURE] Introduce native support for Symfony Console

Benni Mack CR +2 V +2 Hard +496 −113 updated 02/01/16, 09:22

Commit message

This feature allows to add Commands based on Symfony
Console, and also introduces a new binary located in
typo3/sysext/core/bin/t3console.

This effectively removes the need for typo3/cli_dispatch.phpsh
which is not part of any system extension.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Morton Jonuschat +1
  • Verified V +2
    • Georg Ringer +2
    • Morton Jonuschat +1

Issues 1

Files 11

Review log 16

  1. Benni Mack uploaded patch set 1 01/04/16, 20:38

  2. Benni Mack commented on patch set 1 CR -1 01/04/16, 20:39

    WIP
  3. Benni Mack uploaded patch set 2 01/04/16, 21:29

  4. Wouter Wolters commented on patch set 2 01/04/16, 22:34

    CommandApplication.php:148

    missing @param

    CommandApplication.php:176

    getter for the global be-user?
  5. Benni Mack uploaded patch set 3 01/30/16, 22:59

  6. Benni Mack wrote 01/30/16, 23:12

    Patch set 4: Published edit on patch set 3.
  7. Mathias Brodala commented on patch set 3 01/30/16, 23:15

    LockBackendCommand.php:57

    This style of command handling can get tedious given enough commands on the same class. Maybe the API could be changed a little to map commands to methods? These methods could receive I/O objects just like now.
  8. Benni Mack uploaded patch set 5 01/30/16, 23:31

  9. Benni Mack commented on patch set 5 01/30/16, 23:33

    @mbrodala: yes, could be done. We could even split the class in two Commands. For this small example I chose to do it with this simple check in order to keep the overview. I'm fine with either way.
  10. Georg Ringer uploaded patch set 6 01/31/16, 20:14

  11. Georg Ringer voted on patch set 6 CR +1 V +1 01/31/16, 21:03

  12. Morton Jonuschat uploaded patch set 7 02/01/16, 06:29

  13. Morton Jonuschat voted on patch set 7 CR +1 V +1 02/01/16, 06:30

  14. Georg Ringer voted on patch set 7 CR +1 V +1 02/01/16, 07:00

  15. Georg Ringer voted on patch set 7 CR +2 V +2 02/01/16, 09:22

  16. Gerrit merged patch set 7 02/01/16, 09:22