Review main Merged

45603[BUGFIX] Harden fallback class map generation

Helmut Hummel CR +2 V +2 Normal +69 −104 updated 01/13/16, 09:49

Commit message

It could happen when an extension does not provide any
autoload definition, that valid classes are not or
invalid classes are taken into account during class map generation.

To fix this, update to latest composer code that supports
a blacklist for class map generation and provide tests
folder and ext_update files as valid black list.

Also add "Resources" and "res" folder to black list, which
very often also contain php classes, which are then manually required.

Also fix, streamline and add tests to verify this behavior.

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2
    • Benni Mack +2
    • Wouter Wolters +1

Issues 1

Files 5

Review log 9

  1. Helmut Hummel uploaded patch set 1 01/06/16, 14:30

  2. Benni Mack voted on patch set 1 CR +1 01/07/16, 09:42

  3. Benni Mack voted on patch set 1 V +1 01/07/16, 20:47

  4. Wouter Wolters commented on patch set 1 CR +1 V +1 01/07/16, 21:26

    waiting for the functionals to get fixed to merge this one.
  5. Benni Mack voted on patch set 1 CR +2 V +2 01/07/16, 21:30

  6. Benni Mack commented on patch set 1 01/07/16, 21:31

    might be breaking for v7 - when excluding Resources and res?
  7. Helmut Hummel commented on patch set 1 01/12/16, 20:11

    > might be breaking for v7 - when excluding Resources and res? Well that classes were found in res or Resources was the bug which is now fixed with this change
  8. Gerrit merged patch set 1 01/13/16, 09:49

  9. Wouter Wolters commented on patch set 2 01/13/16, 09:49

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit d459ffc67d9a2401fd7109a7a5c661b45422ed96