Review main Merged

45632[TASK] Replace abandoned IDNA converter

Mathias Brodala CR +2 V +2 Normal +55 −55 updated 01/07/16, 22:27

Commit message

The package "phpwhois/idna-convert" was abandoned in favor of
the package "mso/idna-convert".

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Wouter Wolters +1

Issues 1

Files 2

Review log 9

  1. Mathias Brodala uploaded patch set 1 01/07/16, 12:11

  2. Wouter Wolters wrote 01/07/16, 21:39

    Patch set 2: Commit message was updated.
  3. Wouter Wolters rebased onto patch set 3 01/07/16, 21:42

  4. Wouter Wolters voted on patch set 3 CR +1 V +1 01/07/16, 21:43

  5. Markus Klein commented on patch set 3 01/07/16, 21:54

    not sure about that one line

    composer.lock:392

    this change seems wrong
  6. Wouter Wolters commented on patch set 3 01/07/16, 22:01

    composer.lock:392 Reply

    I only updated the added package and removed the abandoned one. This is done by composer it self.
  7. Markus Klein voted on patch set 3 CR +2 V +2 01/07/16, 22:26

  8. Gerrit merged patch set 3 01/07/16, 22:26

  9. Markus Klein commented on patch set 4 01/07/16, 22:27

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit b61c819ac0aa5a840bc16964281f1584f6eab112