Review main Merged

45652[BUGFIX] Render success message again in InfoboxViewHelper

Wouter Wolters CR +2 V +2 Easy +6 −1 updated 01/08/16, 09:50

Commit message

The function forceIntegerInRange can't handle the value zero.
Use isIntegerInRange instead.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Georg Tiefenbrunn +1
    • Markus Klein +1
  • Verified V +2
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Georg Tiefenbrunn +1
    • Markus Klein +1

Issues 1

Files 1

Review log 8

  1. Wouter Wolters uploaded patch set 1 01/07/16, 16:41

  2. Wouter Wolters wrote 01/07/16, 16:42

    Patch set 2: Commit message was updated.
  3. Markus Klein voted on patch set 2 CR +1 V +1 01/07/16, 18:12

  4. Daniel Goerz voted on patch set 2 CR +1 V +1 01/08/16, 09:38

  5. Georg Tiefenbrunn commented on patch set 2 CR +1 V +1 01/08/16, 09:47

    Code-Review+1 Verified+1
  6. Andreas Kienast voted on patch set 2 CR +2 V +2 01/08/16, 09:50

  7. Gerrit merged patch set 2 01/08/16, 09:50

  8. Andreas Kienast commented on patch set 3 01/08/16, 09:50

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 0b1dfff726817e4120ec5df3ca9ec59221431954