Review main Merged

45663[FEATURE] Auto-detect charset conversion

Benni Mack CR +2 V +2 Hard +47 −248 updated 05/29/16, 13:56

Commit message

The CharsetConverter previously had to be configured
to detect if mbstring or iconv or TYPO3's homemade code
via the $TYPO3_CONF_VARS options.

Since CharsetConverter is now a singleton, the check
which conversion strategy should be chosen is now done
during runtime once every request, where mbstring
takes precedence over iconv.

The feature detection in the Install Tool is removed.

Review

  • Code review CR +2
    • Georg Ringer +2
  • Verified V +2
    • Georg Ringer +2

Issues 1

Files 13

Review log 8

  1. Benni Mack uploaded patch set 1 01/07/16, 20:21

  2. Wouter Wolters commented on patch set 1 CR -1 01/07/16, 21:32

    on it
  3. Wouter Wolters uploaded patch set 2 01/07/16, 21:37

  4. Wouter Wolters voted on patch set 2 CR +1 V +1 01/07/16, 21:37

  5. Georg Ringer uploaded patch set 3 01/08/16, 04:50

  6. Georg Ringer voted on patch set 3 CR +2 V +2 01/08/16, 04:50

  7. Gerrit merged patch set 3 01/08/16, 04:50

  8. Markus Klein commented on patch set 4 05/29/16, 13:56

    Post -1: You forgot to remove the according HTML templates in Install Tool.