Review main Merged

45669[TASK] Move publicly accessible files to typo3temp/assets/

Benni Mack CR +2 V +2 Normal +92 −71 updated 01/20/16, 12:29

Commit message

New folder structure is given which contains all files
(images, css, js) which need to be accessible for the
web client.

Also, the folders have been named properly:
- typo3temp/pics/ is now typo3temp/images/
- The typo3temp/temp/ directory which was previously
used for storing temporary images when doing complex
image masking etc. is now named
typo3temp/assets/transient/ which also contains some
volatile files when creating online media records before
FAL processes the file.

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
    • Morton Jonuschat +1
  • Verified V +2
    • Markus Klein +2
    • Morton Jonuschat +1

Issues 1

Files 18

Review log 18

  1. Benni Mack uploaded patch set 1 01/07/16, 22:29

  2. Markus Klein wrote 01/07/16, 22:35

    Patch set 2: Commit message was updated.
  3. Benni Mack uploaded patch set 3 01/08/16, 08:10

  4. Benni Mack uploaded patch set 4 01/08/16, 08:18

  5. Mathias Schreiber commented on patch set 4 CR +1 V +1 01/08/16, 08:51

    I agree that an rst could not harm here
  6. Andreas Kienast voted on patch set 4 CR +1 01/08/16, 10:09

  7. Markus Klein commented on patch set 4 CR -1 01/08/16, 10:10

    definitely an rst please, which explains the idea and why we do that.

    GraphicalFunctions.php:218

    where do we ensure that this folder is already present? $this->createTempSubDir() does not care about that!

    ImageViewHelper.php:47

    images

    ImageViewHelper.php:56

    images

    GifBuilder.php:391

    IMO this should be below the typo3temp/assets/images/ folder and not directly in assets
  8. Mathias Schreiber commented on patch set 4 01/08/16, 10:29

    ImageViewHelper.php:56 Reply

    did we make sure that `EXT:myext/Resources/Public/typo3_logo.png` results in `[b4c0e7ed5c].png`? You get my point
  9. Benni Mack commented on patch set 4 01/08/16, 12:01

    GraphicalFunctions.php:218 Reply

    Installation Process + Install Tool

    GifBuilder.php:391 Reply

    well, I think we should put everything just in assets/images/ as it is the same as GraphicalFunctions and GifBuilder is used the same way. Agreed?
  10. Benni Mack uploaded patch set 5 01/08/16, 12:19

  11. Benni Mack uploaded patch set 6 01/08/16, 12:57

  12. Markus Klein wrote 01/08/16, 13:31

    Patch set 7: Published edit on patch set 6.
  13. Markus Klein voted on patch set 7 CR +1 V +1 01/08/16, 13:39

  14. Wouter Wolters commented on patch set 7 CR +1 01/08/16, 15:04

    will try to verify later today
  15. Morton Jonuschat voted on patch set 7 CR +1 V +1 01/08/16, 16:34

  16. Markus Klein voted on patch set 7 CR +2 V +2 01/08/16, 16:46

  17. Gerrit merged patch set 7 01/08/16, 16:46

  18. Markus Klein commented on patch set 8 01/20/16, 12:29

    AbstractOnlineMediaHelper.php:115

    Regression here, this is still used in \TYPO3\CMS\Core\Resource\OnlineMedia\Helpers\YouTubeHelper::getPreviewImage to be fixed with https://review.typo3.org/46096