45669[TASK] Move publicly accessible files to typo3temp/assets/
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Wouter Wolters +1
- Morton Jonuschat +1
-
Verified V +2
- Markus Klein +2
- Morton Jonuschat +1
Issues 1
Files 18
- typo3/sysext/backend/Classes/Controller/BackendController.php+1 −1
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+1 −1
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php2+10 −9
- typo3/sysext/core/Classes/Resource/OnlineMedia/Helpers/AbstractOnlineMediaHelper.php1+5 −18
- typo3/sysext/core/Classes/Resource/OnlineMedia/Processing/PreviewProcessing.php+1 −1
- typo3/sysext/core/Classes/Resource/ResourceCompressor.php+3 −3
- typo3/sysext/core/Classes/Resource/ResourceFactory.php+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Important-72580-PubliclyAccessibleGeneratedAssetFilesMovedToTypo3tempassets.rstnew+14 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ImageViewHelper.php2+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/ImageViewHelper.php1+1 −1
- typo3/sysext/frontend/Classes/Imaging/GifBuilder.php2+3 −3
- typo3/sysext/frontend/Classes/Page/PageGenerator.php+2 −2
- typo3/sysext/install/Classes/Controller/Action/Ajax/ExtensionCompatibilityTester.php+2 −2
- typo3/sysext/install/Classes/FolderStructure/DefaultFactory.php+33 −21
- typo3/sysext/install/Classes/Report/InstallStatusReport.php+10 −3
- typo3/sysext/install/Tests/Unit/Controller/Action/Ajax/ExtensionCompatibilityTesterTest.php+2 −2
- typo3/sysext/rtehtmlarea/Classes/Form/Element/RichTextElement.php+1 −1
- typo3/sysext/rtehtmlarea/Classes/RteHtmlAreaApi.php+1 −1
Review log 18
-
Benni Mack uploaded patch set 1 01/07/16, 22:29
-
Markus Klein wrote 01/07/16, 22:35
Patch set 2: Commit message was updated. -
Benni Mack uploaded patch set 3 01/08/16, 08:10
-
Benni Mack uploaded patch set 4 01/08/16, 08:18
-
Mathias Schreiber commented on patch set 4 CR +1 V +1 01/08/16, 08:51
I agree that an rst could not harm here -
Andreas Kienast voted on patch set 4 CR +1 01/08/16, 10:09
-
Markus Klein commented on patch set 4 CR -1 01/08/16, 10:10
definitely an rst please, which explains the idea and why we do that.GraphicalFunctions.php:218where do we ensure that this folder is already present? $this->createTempSubDir() does not care about that!ImageViewHelper.php:47imagesImageViewHelper.php:56imagesGifBuilder.php:391IMO this should be below the typo3temp/assets/images/ folder and not directly in assets -
Mathias Schreiber commented on patch set 4 01/08/16, 10:29
ImageViewHelper.php:56Replydid we make sure that `EXT:myext/Resources/Public/typo3_logo.png` results in `[b4c0e7ed5c].png`? You get my point -
Benni Mack commented on patch set 4 01/08/16, 12:01
GraphicalFunctions.php:218ReplyInstallation Process + Install ToolGifBuilder.php:391Replywell, I think we should put everything just in assets/images/ as it is the same as GraphicalFunctions and GifBuilder is used the same way. Agreed? -
Benni Mack uploaded patch set 5 01/08/16, 12:19
-
Benni Mack uploaded patch set 6 01/08/16, 12:57
-
Markus Klein wrote 01/08/16, 13:31
Patch set 7: Published edit on patch set 6. -
Markus Klein voted on patch set 7 CR +1 V +1 01/08/16, 13:39
-
Wouter Wolters commented on patch set 7 CR +1 01/08/16, 15:04
will try to verify later today -
Morton Jonuschat voted on patch set 7 CR +1 V +1 01/08/16, 16:34
-
Markus Klein voted on patch set 7 CR +2 V +2 01/08/16, 16:46
-
Gerrit merged patch set 7 01/08/16, 16:46
-
Markus Klein commented on patch set 8 01/20/16, 12:29
AbstractOnlineMediaHelper.php:115Regression here, this is still used in \TYPO3\CMS\Core\Resource\OnlineMedia\Helpers\YouTubeHelper::getPreviewImage to be fixed with https://review.typo3.org/46096