Review main Abandoned

45679[BUGFIX] Translate lang-keys with spaces in front

Stefan Froemken CR 0 V 0 Easy +2 −0 updated 02/26/16, 07:34

Commit message

In case of flexform configurations with
lang-keys in next row the lang-key is displayed
in flexform instead of the translated value

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 13

  1. Stefan Froemken uploaded patch set 1 01/08/16, 08:31

  2. Xavier Perseguers commented on patch set 1 CR +1 01/08/16, 08:46

    looks good, thinking about possible side effects but none at the moment
  3. Andreas Kienast voted on patch set 1 CR +1 01/08/16, 09:20

  4. Markus Klein commented on patch set 1 01/08/16, 09:20

    This is really strange... I fixed such an issue for master already in FormEngine (for LLL inside flexforms)
  5. Markus Klein commented on patch set 1 CR -2 01/08/16, 09:21

    I want to check something
  6. Markus Klein commented on patch set 1 01/08/16, 09:24

    The related issue was: https://forge.typo3.org/issues/72581 So this should actually work on master
  7. Andreas Kienast commented on patch set 1 CR 0 01/08/16, 09:26

    Xavier got the issue in 6.2.17 and your (Markus) patch was not backported to 6.2. Should we backport yours instead?
  8. Markus Klein commented on patch set 1 CR 0 01/08/16, 09:28

    I can't remember why we didn't solve it this way, but there was some reason. I would prefer to have that fixed in the flexforms handling area.

    LanguageService.php:273

    In this case we must pass through the input unchanged!
  9. Markus Klein commented on patch set 1 CR -1 01/08/16, 18:31

    Please check if this is really an issue on 7.6+
  10. Daniel Goerz commented on patch set 1 CR -1 V -1 01/10/16, 20:47

    This issue does neither exist on master nor on 7.6. So if this is "crucial enough" we should backport the patch from Markus and abandon here.
  11. Stefan Froemken commented on patch set 1 01/20/16, 07:16

    You're right. It works on current master and I'm sure it will work on 7.6, too.
  12. Daniel Goerz commented on patch set 1 02/08/16, 17:07

    Stefan could you abandon this patch please?
  13. Stefan Froemken abandoned the change 02/26/16, 07:34

    Solved within another patch