Review main Merged

45685[TASK] Use csConv API methods

Benni Mack CR +2 V +2 Easy +17 −17 updated 01/08/16, 19:50

Commit message

There are several places in the core that use
TYPO3's homebrew charset conversion over the configured mbstring/iconv selection.

The change modifies the places to use the API methods
instead.

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2
    • Morton Jonuschat +2
    • Wouter Wolters +1

Issues 1

Files 7

Review log 7

  1. Benni Mack uploaded patch set 1 01/08/16, 10:24

  2. Wouter Wolters commented on patch set 1 01/08/16, 10:34

    ContentObjectRenderer.php:3948

    order is different than the one below, which is correct?
  3. Benni Mack commented on patch set 1 01/08/16, 11:44

    ContentObjectRenderer.php:3948 Reply

    The one is utf8_encode the other one utf8_decode :)
  4. Andreas Kienast voted on patch set 1 CR +1 01/08/16, 11:50

  5. Wouter Wolters voted on patch set 1 CR +1 V +1 01/08/16, 18:37

  6. Morton Jonuschat voted on patch set 1 CR +2 V +2 01/08/16, 19:50

  7. Gerrit merged patch set 1 01/08/16, 19:50