Review main Merged Breaking

45695[!!!][TASK] Cleanup and remove old filefunc logic

Benni Mack CR +2 V +2 Hard +118 −292 updated 09/20/16, 16:24

Commit message

The BasicFileUtility was used before FAL also for
checking file mounts and paths, and is only used
for legacy files now. A lot of that code can therefore be removed.

First of all, the init() function was replaced by a real
constructor. A possibility to set the file extension
permissions was added.

Removed DefaultConfiguration
- TYPO3_CONF_VARS[BE][fileExtensions][ftpspace]

Removed properties:
- getUniqueNamePrefix
- tempFN
- f_ext
- mounts
- webPath
- isInit

Removed methods:
- checkPathAgainstMounts()
- findFirstWebFolder()
- slashPath()
- is_webpath()
- checkIfFullAccess()
- init()

Methods that are now protected
- is_directory()
- is_allowed()

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
  • Verified V +2
    • Anja Leichsenring +2
    • Wouter Wolters +1

Issues 1

Files 7

Review log 2328

Show 3 earlier messages
  1. Benni Mack uploaded patch set 1 01/08/16, 11:42

  2. Benni Mack commented on patch set 1 CR -1 01/08/16, 14:51

    still some todos left
  3. Benni Mack uploaded patch set 2 01/08/16, 20:43

  1. Benni Mack uploaded patch set 3 01/22/16, 13:06

  2. Benni Mack uploaded patch set 4 03/04/16, 12:51

  3. Anja Leichsenring wrote 03/04/16, 14:20

    Patch set 5: Commit message was updated.
  4. Anja Leichsenring wrote 03/04/16, 14:24

    Patch set 6: Published edit on patch set 5.
  5. Benni Mack uploaded patch set 7 04/16/16, 11:29

  6. Benni Mack uploaded patch set 8 05/15/16, 21:47

  7. Benni Mack uploaded patch set 9 05/22/16, 12:05

  8. Benni Mack uploaded patch set 10 07/05/16, 16:22

  9. TYPO3com voted on patch set 10 V +1 07/05/16, 16:25 Completed build in 03m 54s on Tue, 5 Jul, 06:25 PM Test Summary: 9651 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-470

  10. Benni Mack uploaded patch set 11 07/20/16, 20:56

  11. TYPO3com voted on patch set 11 V -1 07/20/16, 21:00 Completed build in 04m 33s on Wed, 20 Jul, 11:00 PM Test Summary: 19320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1207

  12. Benni Mack uploaded patch set 12 07/28/16, 06:11

  13. TYPO3com voted on patch set 12 V +1 07/28/16, 06:15 Completed build in 04m 22s on Thu, 28 Jul, 08:15 AM Test Summary: 19378 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1414

  14. Benni Mack commented on patch set 12 CR -1 08/02/16, 06:09

    - description is wrong - webspace is not migrated to one level up, so we keep this change for now. - will update
  15. Benni Mack uploaded patch set 13 08/02/16, 10:44

  16. TYPO3com voted on patch set 13 V +1 08/02/16, 10:54 Completed build in 08m 15s on Tue, 2 Aug, 12:54 PM Test Summary: 19380 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1572

  17. Anja Leichsenring voted on patch set 13 CR +1 V +1 08/03/16, 16:31

  18. Wouter Wolters commented on patch set 13 08/03/16, 17:57

    BasicFileUtility.php:97

    ===

    BasicFileUtility.php:101

    ===

    BasicFileUtility.php:106

    ===

    BasicFileUtility.php:109

    ===

    Breaking-77182-RemovedBasicFileUtilityMethodsAndProperties.rst:16

    has been

    Breaking-77182-RemovedBasicFileUtilityMethodsAndProperties.rst:24

    has been

    Breaking-77182-RemovedBasicFileUtilityMethodsAndProperties.rst:32

    has been
  19. Benni Mack commented on patch set 14 08/03/16, 18:01

    Published edit on patch set 13.
  20. Wouter Wolters voted on patch set 14 CR +1 V +1 08/03/16, 18:02

  21. Anja Leichsenring voted on patch set 14 CR +2 V +2 08/03/16, 18:03

  22. Gerrit merged patch set 14 08/03/16, 18:03

  23. TYPO3com commented on patch set 14 08/03/16, 18:09 Completed build in 07m 10s on Wed, 3 Aug, 08:09 PM Test Summary: 18515 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1749

  24. Nicole Hummel commented on patch set 15 09/20/16, 16:11

    Post -1 This patch doesn't care about the usage of \TYPO3\CMS\Core\Utility\File\ExtendedFileUtility::init() which extends the \TYPO3\CMS\Core\Utility\File\BasicFileUtility I will push an update
  25. Nicole Hummel commented on patch set 15 09/20/16, 16:24