Review main Merged Breaking

45817[!!!][TASK] RTE Remove relative path calculation options

Benni Mack CR +2 V +2 Normal +25 −45 updated 01/14/16, 13:09

Commit message

The RTE has no calculations anymore for defining the
relPath (thus, it's always empty) and can be removed safely.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Wolfgang Klinger +1
    • Susi Moog +1
  • Verified V +2
    • Anja Leichsenring +2
    • Susi Moog +1

Issues 1

Files 4

Review log 11

  1. Benni Mack uploaded patch set 1 01/11/16, 16:03

  2. Benni Mack uploaded patch set 2 01/13/16, 07:04

  3. Wouter Wolters commented on patch set 2 CR -1 01/13/16, 20:13

    RteHtmlParser.php:1047

    $taglist is unused now
  4. Benni Mack commented on patch set 2 CR -2 01/13/16, 22:30

    RteHtmlParser.php:1047 Reply

    strange, this method should not be connected to the other removal. will tackle that tomorrow morning.
  5. Benni Mack uploaded patch set 3 01/14/16, 07:35

  6. Benni Mack voted on patch set 3 CR 0 01/14/16, 07:36

  7. Xavier Perseguers wrote 01/14/16, 07:45

    Patch set 4: Published edit on patch set 3.
  8. Wolfgang Klinger voted on patch set 4 CR +1 01/14/16, 09:14

  9. Susi Moog voted on patch set 4 CR +1 V +1 01/14/16, 13:04

  10. Anja Leichsenring voted on patch set 4 CR +2 V +2 01/14/16, 13:09

  11. Gerrit merged patch set 4 01/14/16, 13:09