Review main Merged

45859[TASK] Remove usage of $GLOBALS[SOBE]

Benni Mack CR +2 V +2 Easy +20 −4 updated 01/14/16, 15:55

Commit message

The page position map for web_layout uses
a simple linkThisScript method and calls the global
variable.

The change includes the tiny adaptions in the own
class as well, to remove the dependency on
$GLOBALS[SOBE] for this use case.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Georg Ringer +1
  • Verified V +2
    • Wouter Wolters +2
    • Georg Ringer +1

Issues 1

Files 1

Review log 8

  1. Benni Mack uploaded patch set 1 01/13/16, 07:54

  2. Andreas Kienast voted on patch set 1 CR +1 01/13/16, 09:09

  3. Wouter Wolters voted on patch set 1 CR +1 V +1 01/13/16, 14:37

  4. Reinhard Führicht uploaded patch set 2 01/14/16, 10:45

  5. Reinhard Führicht commented on patch set 2 01/14/16, 10:47

    ContentLayoutPagePositionMap.php:45

    Changed array() to []. You used [] for on call, but not for the other 2.
  6. Georg Ringer voted on patch set 2 CR +1 V +1 01/14/16, 15:45

  7. Wouter Wolters voted on patch set 2 CR +2 V +2 01/14/16, 15:55

  8. Gerrit merged patch set 2 01/14/16, 15:55