Review main Merged

45878[BUGFIX] Initialize ExtendedFileUtility only if an actual upload happens

Georg Ringer CR +2 V +2 Easy +3 −1 updated 01/15/16, 20:20

Commit message

There is no need to initialize ExtendedFileUtility every request in
EXT:impexp. Check if an upload is actually performed.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Susi Moog +1
  • Verified V +2
    • Anja Leichsenring +2
    • Susi Moog +1

Issues 1

Files 1

Review log 12

  1. Georg Ringer uploaded patch set 1 01/14/16, 10:08

  2. Andreas Kienast voted on patch set 1 CR +1 01/14/16, 10:09

  3. Wolfgang Klinger voted on patch set 1 CR +1 01/14/16, 10:12

  4. Reinhard Führicht uploaded patch set 2 01/14/16, 10:28

  5. Reinhard Führicht commented on patch set 2 01/14/16, 12:05

    ImportExportController.php:168

    $this->uploadedFiles is used here too, maybe checkUpload() should be moved up again?
  6. Susi Moog commented on patch set 2 CR -1 01/14/16, 13:19

    Reinhard is right, the functionality is also needed for the thumbnails in the export case - which by the way does not really work, because the thumbnail image gets uploaded to fileadmin/user_upload/_temp_/importexport/ which has an .htaccess file denying access and therefor making it impossible to display the image in the backend. To achieve what you describe in the commit message I would probably move checkUpload back to where it was and add some logic in checkUpload (maybe checking if GP('file') isset would be enough?). What do you think?
  7. Georg Ringer commented on patch set 2 01/14/16, 13:48

    this will be removed with https://review.typo3.org/#/c/45881/
  8. Anja Leichsenring voted on patch set 2 CR +1 V +1 01/14/16, 15:00

  9. Susi Moog voted on patch set 2 CR +1 V +1 01/14/16, 15:31

  10. Anja Leichsenring voted on patch set 2 CR +2 V +2 01/14/16, 17:38

  11. Gerrit merged patch set 2 01/14/16, 17:38

  12. Markus Klein commented on patch set 3 01/15/16, 20:20

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 1f98394c7ed947391ce422b568a7b1aecf32b254