Review main Merged

45885[TASK] Extract preset logic into separate class in EXT:impexp

Georg Ringer CR +2 V +2 Hard +194 −136 updated 01/15/16, 20:19

Commit message

Move the preset logic into a separate PresetRepository to
improve readability of ImportExportController.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Markus Klein +1
  • Verified V +2
    • Anja Leichsenring +2
    • Markus Klein +1

Issues 1

Files 2

Review log 11

  1. Georg Ringer uploaded patch set 1 01/14/16, 13:27

  2. Georg Ringer uploaded patch set 2 01/14/16, 13:30

  3. Susi Moog voted on patch set 2 CR +1 V +1 01/14/16, 13:36

  4. Anja Leichsenring commented on patch set 2 01/14/16, 14:18

    ImportExportController.php:891

    what is this line good for?
  5. Anja Leichsenring wrote 01/14/16, 14:21

    Patch set 3: Published edit on patch set 2.
  6. Anja Leichsenring voted on patch set 3 CR +1 V +1 01/14/16, 14:23

  7. Markus Klein wrote 01/14/16, 14:52

    Patch set 4: Commit message was updated.
  8. Markus Klein voted on patch set 4 CR +1 V +1 01/14/16, 14:52

  9. Anja Leichsenring voted on patch set 4 CR +2 V +2 01/14/16, 14:52

  10. Gerrit merged patch set 4 01/14/16, 14:52

  11. Markus Klein commented on patch set 5 01/15/16, 20:19

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit a8dbf28b8aef64bcc5e376d88440abbb0876e59e