Review main Merged

45901[TASK] Allow access to visible content within /.well-known/ directory

Cedric Ziel CR +2 V +2 Easy +3 −1 updated 01/15/16, 10:33

Commit message

Allow access to the visible content from within the `/.well-known/`
hidden directory. The access to all other hidden files and directories
(starting with a dot) is still blocked.

The /.well-known/ directory represents the standard (RFC 5785) path
prefix for "well-known locations", and therefore, access to its visible
content should not be blocked.

Review

  • Code review CR +2
    • Benni Mack +2
    • Georg Ringer +1
    • Andreas Kienast +1
    • Morton Jonuschat +1
  • Verified V +2
    • Benni Mack +2
    • Morton Jonuschat +1

Issues 1

Files 1

Review log 11

  1. Cedric Ziel uploaded patch set 1 01/14/16, 18:27

  2. Cedric Ziel updated the commit message in patch set 2 01/14/16, 18:29

  3. Steffen Gebert commented on patch set 2 CR -1 01/14/16, 20:19

    While I am in very favor of letsencrypt, I think such specialities shouldn't be added to TYPO3's .htaccess template.
  4. Cedric Ziel commented on patch set 2 01/14/16, 20:34

    While I think I understand why you argue that way, I strongly believe in making things easy as the best way. I see no point in not adding the single line and saving people an extra step and potentially trouble for easily obtaining a certificate. I see more points for the entry, than against.
  5. Morton Jonuschat uploaded patch set 3 01/14/16, 21:40

  6. Morton Jonuschat commented on patch set 3 CR +1 V +1 01/14/16, 21:47

    The /.well-known directory is actually a RFC standard from 2010, nothing specific to Lets Encrypt. I've made the match a bit more restrictive and I think it's a valid addition to a "best practice" .htaccess file.
  7. Andreas Kienast voted on patch set 3 CR +1 01/15/16, 05:24

  8. Georg Ringer voted on patch set 3 CR +1 01/15/16, 07:15

  9. Benni Mack voted on patch set 3 CR +2 V +2 01/15/16, 10:32

  10. Gerrit merged patch set 3 01/15/16, 10:32

  11. Benni Mack commented on patch set 4 01/15/16, 10:33

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit b9db81701ac79141ae0bb98b954c23600c0fbdfe