Review main Merged

45913[TASK] Deprecate f:format.html in the backend context

Georg Ringer CR +2 V +2 Easy +28 −0 updated 03/31/17, 20:34

Commit message

Using f:format.html in the backend context must be avoided
and is deprecated now.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • Wouter Wolters +1
    • Morton Jonuschat +1
  • Verified V +2
    • Anja Leichsenring +2
    • Daniel Goerz +1

Issues 1

Files 2

Review log 13

  1. Georg Ringer uploaded patch set 1 01/15/16, 07:55

  2. Wouter Wolters commented on patch set 1 01/15/16, 07:57

    HtmlViewHelper.php:98

    deprecated means still working in 8, shouldn't this be CMS 9?
  3. Morton Jonuschat wrote 01/15/16, 07:58

    Patch set 2: Published edit on patch set 1.
  4. Morton Jonuschat voted on patch set 2 CR +1 01/15/16, 07:59

  5. Wouter Wolters voted on patch set 2 CR +1 01/15/16, 07:59

  6. Martin Kutschker commented on patch set 2 01/15/16, 08:42

    Instead of deprectaing the helper I suggest to get rid of the FE dependency (parseFunc).
  7. Georg Ringer commented on patch set 2 01/15/16, 11:58

    in FE the parsefunc is of course needed and valid as this VH is used to render rte content correctly
  8. Anja Leichsenring voted on patch set 2 CR +1 V +1 01/15/16, 12:08

  9. Daniel Goerz voted on patch set 2 CR +1 V +1 01/15/16, 12:57

  10. Anja Leichsenring voted on patch set 2 CR +2 V +2 01/15/16, 13:05

  11. Gerrit merged patch set 2 01/15/16, 13:05

  12. Benni Mack commented on patch set 3 03/27/17, 06:00

    Hey everybody, this patch currently throws some deprecation warnings in the backend (without any extension). Deprecating something without having proper alternatives already in placed inside the core, makes the core in itself inconsistent. Any ideas on how to solve that? Otherwise I'd opt for at least removing the deprecation warning for v8, until we're ready to do have the replacement into place in v9.
  13. Frank Nägler commented on patch set 3 03/31/17, 20:34

    Reverted This patchset was reverted in change: I9667dbc2acd3fec0ed9af29ae995fb6f25aaae92