Review main Merged

45932[BUGFIX] Change deprecation of DocumentTemplate::sectionEnd

Georg Ringer CR +2 V +2 Easy +1 −1 updated 01/15/16, 12:48

Commit message

To avoid regressions deprecation logs in core, the deprecation log entry
is only written in 'sectionEnd()' if the sectionFlag is used.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Anja Leichsenring +2
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Anja Leichsenring +2
    • Markus Klein +1

Issues 1

Files 1

Review log 8

  1. Georg Ringer uploaded patch set 1 01/15/16, 12:23

  2. Wouter Wolters voted on patch set 1 CR +1 01/15/16, 12:24

  3. Markus Klein commented on patch set 1 CR -1 01/15/16, 12:40

    discussing different solution
  4. Georg Ringer uploaded patch set 2 01/15/16, 12:45

  5. Markus Klein voted on patch set 2 CR +1 V +1 01/15/16, 12:47

  6. Anja Leichsenring voted on patch set 2 CR +2 V +2 01/15/16, 12:48

  7. Wouter Wolters voted on patch set 2 CR +2 V +2 01/15/16, 12:48

  8. Gerrit merged patch set 2 01/15/16, 12:48