Review main Merged

45993[BUGFIX] Clean up inconsistent data from import

Bernhard Kraft CR +2 V +2 Easy +12 −2 updated 03/02/16, 22:34

Commit message

When importing a T3D or XML file the loaded data has to get cleansed
first. The "extensionDependencies" array for example may contain an
empty string which will cause a non-correct warning message in the
importers warning tab.

A new method "cleanupImportData" takes care to bring import data into
an acceptable format.

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Markus Klein +1
  • Verified V +2
    • Morton Jonuschat +2
    • Markus Klein +1

Issues 1

Files 2

Review log 14

  1. Bernhard Kraft uploaded patch set 1 01/16/16, 09:57

  2. Markus Klein wrote 01/16/16, 10:02

    Patch set 2: Commit message was updated.
  3. Markus Klein commented on patch set 2 01/16/16, 10:03

    Import.php:2125

    I prefer an array_filter() here.
  4. Bernhard Kraft commented on patch set 2 CR +1 V +1 01/16/16, 10:14

    I deliberately used array_diff as this would be my preference but I am fine with array_filter too. After discussing this right now we came to the conclusion that array_filter() would be equivalent to array_diff($a, array('', '0'));
  5. Bernhard Kraft uploaded patch set 3 01/16/16, 10:17

  6. Markus Klein voted on patch set 3 CR +1 V +1 01/16/16, 10:23

  7. Morton Jonuschat voted on patch set 3 CR +2 V +2 01/16/16, 12:11

  8. Gerrit merged patch set 3 01/16/16, 12:11

  9. Morton Jonuschat commented on patch set 4 01/16/16, 12:11

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 192c17fdbcdb6712a28b62885437c4de2f9793c5
  10. Nicole Hummel commented on patch set 4 03/02/16, 19:32

    Anyone ever thought about 6.2? Currently 6.2 import is broken due to uncleand export file...
  11. Nicole Hummel commented on patch set 4 03/02/16, 20:04

    To improve compatibility I tend to revert that patch and ensure a clean state on writing the t3d file
  12. Markus Klein commented on patch set 4 03/02/16, 21:23

    @Nicole: Improving the export is another task. This one is mainly to improve compatibiltiy with already existing t3d files
  13. Nicole Hummel commented on patch set 4 03/02/16, 21:44

    But right now we're generatiing files which can be imported in master and 7.6 only! IMHO this is not intended?!
  14. Markus Klein commented on patch set 4 03/02/16, 22:34

    I think it does not make sense to export data from 7+ and import them in 6.2.