45997[TASK] Clipboard: Use new modal confirmation dialog for "Delete Elements"
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Frank Nägler +1
-
Verified V +2
- Wouter Wolters +2
- Frank Nägler +1
Issues 1
Files 2
Review log 26
Show 1 earlier messages
-
Michael Oehlhof uploaded patch set 1 01/16/16, 11:09
-
Jana Kienast commented on patch set 1 V +1 02/17/16, 20:43
Now the box looks like expected -
Christian Kuhn commented on patch set 1 CR -1 02/19/16, 18:24
frank will update the patch.Clipboard.php:292shouldn't this confirm() vanish then? -
Frank Nägler commented on patch set 1 CR -1 02/19/16, 18:25
will push an update later, please wait some hours, need a break now ;) -
Frank Nägler uploaded patch set 2 02/20/16, 22:56
-
Michael Oehlhof voted on patch set 2 CR +1 V +1 02/20/16, 23:18
-
Frank Nägler commented on patch set 2 CR +1 V +1 02/20/16, 23:31
I have pinged Lolli for a review. specially for my construction of the return url. please wait with merge, until Lolli voted. thx. -
Christian Kuhn commented on patch set 2 CR -1 02/21/16, 10:54
Clipboard.php:302nah. benni for the resque? -
Susi Moog commented on patch set 2 CR -1 02/21/16, 11:48
Clipboard.php:302ReplyTypoScriptFrontendController uses: rawurlencode(GeneralUtility::getIndpEnv('REQUEST_URI')))) and the htmlspecialchars should probably be applied to the full $returnUrl not only the first part?Clipboard.php:310for consistency I'd add all the htmlspecialchars down here, so it is clearer that it's done for all the attributes.locallang_alt_doc.xlf:79"these" elements -
Frank Nägler commented on patch set 2 CR -1 02/22/16, 08:42
Clipboard.php:302Replyok, the same style, but another method :) I will change it. thank you :)Clipboard.php:310Replyyes, good idea. I will do this with the next patchsetlocallang_alt_doc.xlf:79Replydone in next patchset -
Frank Nägler uploaded patch set 3 02/22/16, 08:43
-
Frank Nägler uploaded patch set 4 02/22/16, 08:44
-
Frank Nägler voted on patch set 4 CR +1 V +1 02/22/16, 08:45
-
Wouter Wolters commented on patch set 4 02/22/16, 08:49
Clipboard.php:304maybe put languageservice in a variable and use that for the rest.Clipboard.php:307empty string instead of one space. The extra space is added at href again. -
Frank Nägler uploaded patch set 5 02/22/16, 15:29
-
Frank Nägler voted on patch set 5 CR +1 V +1 02/22/16, 15:30
-
Wouter Wolters voted on patch set 5 CR +1 02/22/16, 15:49
-
Benni Mack commented on patch set 5 CR -1 02/23/16, 07:29
Clipboard.php:302please have a look at deleteUrl() and its first parameter. Seems to be the stuff you could use here. -
Frank Nägler uploaded patch set 6 02/23/16, 08:01
-
Frank Nägler commented on patch set 5 02/23/16, 08:01
Clipboard.php:302Replythx, perfect! -
Frank Nägler voted on patch set 6 CR +1 V +1 02/23/16, 08:02
-
Benni Mack wrote 02/23/16, 09:03
Patch set 7: Published edit on patch set 6. -
Frank Nägler voted on patch set 7 CR +1 V +1 02/23/16, 22:08
-
Wouter Wolters voted on patch set 7 CR +2 V +2 02/23/16, 22:21
-
Gerrit merged patch set 7 02/23/16, 22:21
-
Wouter Wolters commented on patch set 8 02/23/16, 22:21
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 69abdcea3973cf5e92e59079128abed78807db1b