Review main Merged

45998[BUGFIX] Import/Export Various Exceptions happening

Reinhard Führicht CR +2 V +2 Easy +16 −5 updated 01/16/16, 14:28

Commit message

Fixed exception shown when

1) uploading an existing file without "Overwrite" setting activated
2) opening export module as a non-admin
3) opening import module as a non-admin without permission
   to access an available file storage

Also improved error message for missing default file upload folder.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Martin Kutschker +1
  • Verified V +2
    • Georg Ringer +2
    • Martin Kutschker +1

Issues 1

Files 2

Review log 7

  1. Reinhard Führicht uploaded patch set 1 01/16/16, 11:10

  2. Martin Kutschker uploaded patch set 2 01/16/16, 13:10

  3. Martin Kutschker voted on patch set 2 CR +1 V +1 01/16/16, 13:11

  4. Georg Ringer voted on patch set 2 CR +2 V +2 01/16/16, 14:23

  5. Gerrit merged patch set 2 01/16/16, 14:23

  6. Georg Ringer commented on patch set 3 01/16/16, 14:24

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 5588062ca49b78c250c8928e642789fb463b8740
  7. Markus Klein commented on patch set 3 01/16/16, 14:28

    CGL comment, maybe fix with another changeset in that area later.

    ImportExportController.php:175

    missing space

    ImportExportController.php:837

    missing space