Review main Merged Breaking

46011[!!!][TASK] Remove charset functionality for locales

Benni Mack CR +2 V +2 Hard +45 −292 updated 01/21/16, 08:44

Commit message

The TYPO3 frontend resolves
config.locale_all (e.g. set to de_AT.UTF-8) and stores
it in $TSFE->localeCharset by using a "best guess" based
on decade-old mappings.

$TSFE->localeCharset is only used in stdWrap.strftime
to convert the result from the localeCharset to the ->renderCharset.

However, as it is obvious that a misconfiguration of the system, which happens only when
config.set_locale = de_AT@iso-8859-15
config.renderCharset = utf-8
is set, this exception needs to be configured manually
when using stdWrap.strftime.charset = iso-8859-15

Review

  • Code review CR +2
    • Frank Nägler +2
    • Georg Ringer +1
  • Verified V +2
    • Frank Nägler +2
    • Georg Ringer +1

Issues 1

Files 4

Review log 15

  1. Benni Mack uploaded patch set 1 01/16/16, 13:34

  2. Andreas Kienast commented on patch set 1 CR -1 01/16/16, 15:30

    Removing public functions is imo a breaking change. Also, the ticket is missing.
  3. Georg Ringer commented on patch set 1 01/16/16, 16:06

    pretty sure it is a wip ;)
  4. Benni Mack commented on patch set 1 CR -1 01/18/16, 06:45

    Yeah, question is, if we really should drop this functionality or if it should be kept for a good reason.
  5. Benni Mack uploaded patch set 2 01/20/16, 09:19

  6. Georg Ringer voted on patch set 2 CR +1 V +1 01/20/16, 11:26

  7. Wouter Wolters commented on patch set 2 01/20/16, 19:08

    sysext/t3editor/Resources/Private/tsref.xml still contains TSFE->localeCharset
  8. Wouter Wolters commented on patch set 2 01/20/16, 19:08

    Rest look good btw.
  9. Frank Nägler voted on patch set 2 CR +1 01/20/16, 20:41

  10. Frank Nägler voted on patch set 2 CR +2 V +2 01/20/16, 20:43

  11. Gerrit merged patch set 2 01/20/16, 20:43

  12. Tymoteusz Motylewski commented on patch set 3 01/20/16, 21:04

    Breaking-72826-RemovedCustomCharsetConfigurationForLocales.rst:8

    shouldn't this sentence be in past tense? it describe status before this patch.
  13. Wouter Wolters commented on patch set 3 01/20/16, 23:29

    post -1, why is my comment ignored?
  14. Benni Mack commented on patch set 3 01/21/16, 06:40

    doing a followup now.
  15. Frank Nägler commented on patch set 3 01/21/16, 08:44

    sorry Wouter, didn't see your comment :/