46011[!!!][TASK] Remove charset functionality for locales
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Georg Ringer +1
-
Verified V +2
- Frank Nägler +2
- Georg Ringer +1
Issues 1
Files 4
- typo3/sysext/core/Classes/Charset/CharsetConverter.php+0 −281
- typo3/sysext/core/Documentation/Changelog/master/Breaking-72826-RemovedCustomCharsetConfigurationForLocales.rst1new+43 −0
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+2 −4
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+0 −7
Review log 15
-
Benni Mack uploaded patch set 1 01/16/16, 13:34
-
Andreas Kienast commented on patch set 1 CR -1 01/16/16, 15:30
Removing public functions is imo a breaking change. Also, the ticket is missing. -
Georg Ringer commented on patch set 1 01/16/16, 16:06
pretty sure it is a wip ;) -
Benni Mack commented on patch set 1 CR -1 01/18/16, 06:45
Yeah, question is, if we really should drop this functionality or if it should be kept for a good reason. -
Benni Mack uploaded patch set 2 01/20/16, 09:19
-
Georg Ringer voted on patch set 2 CR +1 V +1 01/20/16, 11:26
-
Wouter Wolters commented on patch set 2 01/20/16, 19:08
sysext/t3editor/Resources/Private/tsref.xml still contains TSFE->localeCharset -
Wouter Wolters commented on patch set 2 01/20/16, 19:08
Rest look good btw. -
Frank Nägler voted on patch set 2 CR +1 01/20/16, 20:41
-
Frank Nägler voted on patch set 2 CR +2 V +2 01/20/16, 20:43
-
Gerrit merged patch set 2 01/20/16, 20:43
-
Tymoteusz Motylewski commented on patch set 3 01/20/16, 21:04
Breaking-72826-RemovedCustomCharsetConfigurationForLocales.rst:8shouldn't this sentence be in past tense? it describe status before this patch. -
Wouter Wolters commented on patch set 3 01/20/16, 23:29
post -1, why is my comment ignored? -
Benni Mack commented on patch set 3 01/21/16, 06:40
doing a followup now. -
Frank Nägler commented on patch set 3 01/21/16, 08:44
sorry Wouter, didn't see your comment :/