Review main Merged

46021[BUGFIX] Cast pageId to integer before storing a preset in EXT:impexp

Morton Jonuschat CR +2 V +2 Easy +2 −2 updated 01/16/16, 18:22

Commit message

When storing a export preset in EXT:impexp no pageId is being set when
exporting a single table or record instead of a pagetree branch. Cast
the value for the pageId to integer to avoid MySQL strict mode errors.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
  • Verified V +2
    • Anja Leichsenring +2

Issues 1

Files 1

Review log 5

  1. Morton Jonuschat uploaded patch set 1 01/16/16, 17:11

  2. Wouter Wolters voted on patch set 1 CR +1 01/16/16, 18:21

  3. Anja Leichsenring commented on patch set 1 CR +2 V +2 01/16/16, 18:22

    merged as no-brainer (I sat next to him during discovering, analysing and fixing the issue)
  4. Gerrit merged patch set 1 01/16/16, 18:22

  5. Anja Leichsenring commented on patch set 2 01/16/16, 18:22

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit dd1bb70edd5f9575451668a389ac98dfbc9569eb