Review main Merged

46038[TASK] Clean up DatabaseConnection::fullQuoteArray

Nicole Hummel CR +2 V +2 Easy +5 −5 updated 01/19/16, 09:08

Commit message

If the parameter $noQuote equals true, the given array can be returned
directly as there isn't anything to do.

Furthermore the AccessibleMock object from the test method can be
converted into a normal mock.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Morton Jonuschat +1
  • Verified V +2
    • Stefan Neufeind +2
    • Morton Jonuschat +1

Issues 1

Files 2

Review log 4

  1. Nicole Hummel uploaded patch set 1 01/17/16, 21:21

  2. Morton Jonuschat voted on patch set 1 CR +1 V +1 01/19/16, 06:16

  3. Stefan Neufeind voted on patch set 1 CR +2 V +2 01/19/16, 09:08

  4. Gerrit merged patch set 1 01/19/16, 09:08