46039[BUGFIX] Convert slashes in Windows paths for blacklist generation
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Stefan Neufeind +1
- Morton Jonuschat +1
- Xavier Perseguers +1
- Helmut Hummel +1
-
Verified V +2
- Helmut Hummel +2
- Morton Jonuschat +1
Issues 1
Files 1
Review log 11
-
Nicole Hummel uploaded patch set 1 01/17/16, 22:11
-
Helmut Hummel voted on patch set 1 CR +1 V +1 01/17/16, 22:40
-
Morton Jonuschat commented on patch set 1 CR +1 V +1 01/19/16, 06:41
Looks good on OSX, no windows to test if the backslashes are really being replaced though. -
Xavier Perseguers voted on patch set 1 CR +1 01/19/16, 06:43
-
Stefan Neufeind commented on patch set 1 CR +1 01/19/16, 15:03
ClassLoadingInformationGenerator.php:151Should we probably use GeneralUtility::fixWindowsFilePath() to use a central API-method instead of "magic" here? -
Nicole Hummel commented on patch set 1 01/19/16, 15:11
ClassLoadingInformationGenerator.php:151ReplyIMHO not, because composer does strtr itself as well -
Stefan Neufeind commented on patch set 1 01/19/16, 15:18
ClassLoadingInformationGenerator.php:151Replyokay thanks, fine with me then -
Benni Mack voted on patch set 1 CR +2 01/20/16, 08:29
-
Helmut Hummel voted on patch set 1 V +2 01/20/16, 10:52
-
Gerrit merged patch set 1 01/20/16, 10:52
-
Helmut Hummel commented on patch set 2 02/18/16, 23:36
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 216a0fbdd3c9f12d589b40782a67aa6748fc9671