Review main Merged

46077[TASK] ImpExp: Streamline checks for data

Markus Klein CR +2 V +2 Normal +55 −56 updated 01/23/16, 10:46

Commit message

Remove checks where not necessary, add them where necessary.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Wouter Wolters +1
  • Verified V +2
    • Frank Nägler +2
    • Wouter Wolters +1

Issues 1

Files 2

Review log 13

  1. Markus Klein uploaded patch set 1 01/19/16, 13:32

  2. Reinhard Führicht commented on patch set 1 01/19/16, 13:41

    Import.php:344

    Are you sure that the is_array check can be removed for extensionDependencies? I think it could be null too

    ImportExport.php:301

    Same here: Can is_array() be removed?
  3. Markus Klein commented on patch set 1 01/19/16, 14:22

    Import.php:344 Reply

    I checked that. All assignments ensure that we get an array here.

    ImportExport.php:301 Reply

    Same here.
  4. Reinhard Führicht voted on patch set 1 CR +1 V +1 01/19/16, 14:24

  5. Frank Nägler uploaded patch set 2 01/20/16, 19:16

  6. Frank Nägler voted on patch set 2 CR +1 V +1 01/20/16, 19:22

  7. Reinhard Führicht voted on patch set 2 CR +1 V +1 01/21/16, 08:09

  8. Markus Klein uploaded patch set 3 01/22/16, 12:01

  9. Markus Klein commented on patch set 3 01/22/16, 12:02

    rebased
  10. Wouter Wolters voted on patch set 3 CR +1 V +1 01/22/16, 18:40

  11. Frank Nägler voted on patch set 3 CR +1 01/23/16, 10:45

  12. Frank Nägler voted on patch set 3 CR +2 V +2 01/23/16, 10:46

  13. Gerrit merged patch set 3 01/23/16, 10:46