46077[TASK] ImpExp: Streamline checks for data
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Wouter Wolters +1
-
Verified V +2
- Frank Nägler +2
- Wouter Wolters +1
Issues 1
Files 2
Review log 13
-
Markus Klein uploaded patch set 1 01/19/16, 13:32
-
Reinhard Führicht commented on patch set 1 01/19/16, 13:41
ImportExport.php:301Same here: Can is_array() be removed? -
Markus Klein commented on patch set 1 01/19/16, 14:22
Import.php:344ReplyI checked that. All assignments ensure that we get an array here.ImportExport.php:301ReplySame here. -
Reinhard Führicht voted on patch set 1 CR +1 V +1 01/19/16, 14:24
-
Frank Nägler uploaded patch set 2 01/20/16, 19:16
-
Frank Nägler voted on patch set 2 CR +1 V +1 01/20/16, 19:22
-
Reinhard Führicht voted on patch set 2 CR +1 V +1 01/21/16, 08:09
-
Markus Klein uploaded patch set 3 01/22/16, 12:01
-
Markus Klein commented on patch set 3 01/22/16, 12:02
rebased -
Wouter Wolters voted on patch set 3 CR +1 V +1 01/22/16, 18:40
-
Frank Nägler voted on patch set 3 CR +1 01/23/16, 10:45
-
Frank Nägler voted on patch set 3 CR +2 V +2 01/23/16, 10:46
-
Gerrit merged patch set 3 01/23/16, 10:46
Import.php:344