46078[TASK] ImpExp: Streamline checks for data
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Reinhard Führicht +1
-
Verified V +2
- Frank Nägler +2
- Reinhard Führicht +1
Issues 1
Files 2
Review log 8
-
Markus Klein uploaded patch set 1 01/19/16, 13:33
-
Reinhard Führicht voted on patch set 1 CR +1 V +1 01/19/16, 14:25
-
Frank Nägler uploaded patch set 2 01/20/16, 21:26
-
Frank Nägler voted on patch set 2 CR +1 V +1 01/20/16, 21:26
-
Reinhard Führicht voted on patch set 2 CR +1 V +1 01/21/16, 08:09
-
Daniel Goerz commented on patch set 2 01/22/16, 09:03
Import.php:363For better readability one could reverse this condition for an rearly continue. -
Frank Nägler commented on patch set 2 CR +2 V +2 01/25/16, 09:25
@Daniel: because this is the backport and patch on master is already merged, your remarks need a new patch. I think we could change it, but we don't need to change it. -
Gerrit merged patch set 2 01/25/16, 09:25
Import.php:357