46096[BUGFIX] Move all typo3temp files below typo3temp/var or assets
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Wouter Wolters +1
- Frank Nägler +1
-
Verified V +2
- Benni Mack +2
- Frank Nägler +1
Issues 2
Files 44
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectItemsTest.php+1 −1
- typo3/sysext/core/Build/AcceptanceTests.yml+1 −1
- typo3/sysext/core/Build/FunctionalTestsBootstrap.php+2 −1
- typo3/sysext/core/Build/UnitTestsBootstrap.php+2 −1
- typo3/sysext/core/Classes/Compatibility/LoadedExtensionArrayElement.php+2 −2
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php+5 −5
- typo3/sysext/core/Classes/Resource/OnlineMedia/Helpers/AbstractOnlineMediaHelper.php2+19 −2
- typo3/sysext/core/Classes/Resource/OnlineMedia/Processing/PreviewProcessing.php2+3 −1
- typo3/sysext/core/Classes/Utility/GeneralUtility.php2+3 −3
- typo3/sysext/core/Tests/Unit/Configuration/ConfigurationManagerTest.php+14 −14
- typo3/sysext/core/Tests/Unit/Http/StreamTest.php+28 −28
- typo3/sysext/core/Tests/Unit/Localization/LocalizationFactoryTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Resource/ResourceFactoryTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Utility/Fixtures/DeprecationUtilityFixture.php+1 −1
- typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+69 −69
- typo3/sysext/core/Tests/FunctionalTestCaseBootstrapUtility.php+4 −1
- typo3/sysext/core/Tests/UnitTestCase.php1+3 −3
- typo3/sysext/extensionmanager/Classes/Controller/ActionController.php+1 −1
Show 24 more files
- typo3/sysext/extensionmanager/Classes/Utility/FileHandlingUtility.php+3 −3
- typo3/sysext/extensionmanager/Tests/Unit/Utility/FileHandlingUtilityTest.php+14 −14
- typo3/sysext/extensionmanager/Tests/Unit/Utility/InstallUtilityTest.php+5 −5
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+3 −3
- typo3/sysext/frontend/Tests/Unit/Controller/Fixtures/renderedPage.html2+2 −2
- typo3/sysext/impexp/Classes/ImportExport.php+1 −1
- typo3/sysext/indexed_search/Tests/Unit/IndexerTest.php+1 −1
- typo3/sysext/install/Classes/Controller/Action/Ajax/ExtensionCompatibilityTester.php2+0 −3
- typo3/sysext/install/Classes/Controller/Action/Tool/CleanUp.php+2 −2
- typo3/sysext/install/Classes/Controller/Action/Tool/ImportantActions.php+2 −2
- typo3/sysext/install/Classes/Controller/Action/Tool/LoadExtensions.php+1 −1
- typo3/sysext/install/Classes/Controller/Action/Tool/TestSetup.php2+1 −1
- typo3/sysext/install/Classes/FolderStructure/DefaultFactory.php+0 −5
- typo3/sysext/install/Classes/Report/InstallStatusReport.php+0 −1
- typo3/sysext/install/Classes/Service/ClearCacheService.php+1 −1
- typo3/sysext/install/Tests/Unit/Controller/Action/Ajax/ExtensionCompatibilityTesterTest.php+2 −2
- typo3/sysext/install/Tests/Unit/FolderStructure/AbstractNodeTest.php+2 −2
- typo3/sysext/install/Tests/Unit/FolderStructure/DirectoryNodeTest.php+1 −1
- typo3/sysext/install/Tests/Unit/FolderStructure/FileNodeTest.php+2 −2
- typo3/sysext/install/Tests/Unit/FolderStructure/LinkNodeTest.php+7 −7
- typo3/sysext/install/Tests/Unit/FolderStructure/RootNodeTest.php+2 −2
- typo3/sysext/install/Tests/Unit/FolderStructureTestCase.php+1 −1
- typo3/sysext/rsaauth/Classes/Backend/CommandLineBackend.php+1 −1
- typo3/sysext/t3editor/Resources/Private/tsref.xml+1 −1
Review log 49
Show 24 earlier messages
-
Helmut Hummel uploaded patch set 1 01/19/16, 22:35
-
Markus Klein commented on patch set 1 01/19/16, 22:52
I'm not sure about those files generated by tests. Actually it shouldn't matter at all, where those are created, as those must be removed after the test execution anyway. Either by tearDown or the test itself. -
Markus Klein commented on patch set 1 01/19/16, 22:59
GeneralUtility.php:2457must be adjusted too -
Markus Klein wrote 01/19/16, 23:00
Patch set 2: Published edit on patch set 1. -
Markus Klein commented on patch set 1 01/19/16, 23:01
GeneralUtility.php:2457ReplyDone -
Helmut Hummel commented on patch set 2 01/19/16, 23:15
> I'm not sure about those files generated by tests. Well, we now differentiate between private (var) and public (assets) files in typo3temp. By definition, there must now be no file outside of these folders. Imho tests must stick to these standards as well. This change will also make it easieer for us to make these two locations configurable and made available through API -
Markus Klein voted on patch set 2 CR +1 01/19/16, 23:39
-
Markus Klein uploaded patch set 3 01/20/16, 00:19
-
Markus Klein commented on patch set 3 CR +1 V +1 01/20/16, 00:20
Fixed the test for the deprecation log to also remove the directory created. var/tests/ is now empty for me after running all unittests. Only var/transient still contains some foo* files, which I did not find where those stem from. -
Georg Ringer voted on patch set 3 CR +1 01/20/16, 05:12
-
Wouter Wolters voted on patch set 3 CR +1 01/20/16, 07:58
-
Benni Mack uploaded patch set 4 01/20/16, 10:43
-
Benni Mack commented on patch set 4 CR +1 V +1 01/20/16, 10:43
Tests failed when I deleted typo3temp/ and ran the tests because some directories could be created. Changed the Bootstrap files of the tests. -
Nicole Hummel commented on patch set 3 01/20/16, 10:46
UnitTestCase.php:86Should be removed as the test is only for typo3temp/var/renderedPage.html:19Should be "moved" to the css folder inside assetsrenderedPage.html:23Same hereExtensionCompatibilityTester.php:58Not sure if both files have to be accessible -
Nicole Hummel commented on patch set 4 CR -1 01/20/16, 10:48
On it -
Markus Klein commented on patch set 4 CR -1 V -1 01/20/16, 12:29
Regression fix for YoutubeHelper must be integrated -
Markus Klein commented on patch set 4 01/20/16, 12:30
-
Markus Klein uploaded patch set 5 01/20/16, 14:21
-
Markus Klein commented on patch set 5 01/20/16, 14:27
Nicole's comments are not yet tackled -
Helmut Hummel commented on patch set 3 01/20/16, 14:39
ExtensionCompatibilityTester.php:58Replyyes, they have to be accessible -
Helmut Hummel uploaded patch set 6 01/20/16, 14:39
-
Helmut Hummel commented on patch set 6 01/20/16, 14:40
@Markus: I changed the fix you pushed a bit. can you check if this is fine with you? Imho we do not need to check if the directory is there, as the install tool checks this already -
Helmut Hummel uploaded patch set 7 01/20/16, 14:45
-
Markus Klein commented on patch set 7 01/20/16, 14:54
> Imho we do not need to check if the directory is there, as the install tool checks this already This is not enough. There are many people out there which are used to truncate typo3temp. The install tool thingy is nice, but not sufficient and only called on initial setup.
-
Markus Klein commented on patch set 7 01/20/16, 14:56
AbstractOnlineMediaHelper.php:119PSR2PreviewProcessing.php:109This conflicts with my change in https://review.typo3.org/#/c/46110/1/typo3/sysext/core/Classes/Resource/OnlineMedia/Processing/PreviewProcessing.php This file must be cleaned up outside of this if, because it is there even if $temporaryFileNameForResizedThumb is not a file. -
Markus Klein commented on patch set 7 01/20/16, 14:58
PreviewProcessing.php:109ReplyI removed my change from the other patch -
Markus Klein wrote 01/20/16, 14:59
Patch set 8: Published edit on patch set 7. -
Helmut Hummel uploaded patch set 9 01/20/16, 15:10
-
Helmut Hummel commented on patch set 9 01/20/16, 15:11
fixed another regression from https://review.typo3.org/#/c/42385/ to be able to properly test the online media stuff :-/ -
Helmut Hummel rebased onto patch set 10 01/20/16, 15:23
-
Markus Klein uploaded patch set 11 01/20/16, 15:40
-
Markus Klein uploaded patch set 12 01/20/16, 15:45
-
Markus Klein voted on patch set 12 CR +1 V +1 01/20/16, 15:46
-
Helmut Hummel voted on patch set 12 CR +1 V +1 01/20/16, 15:53
-
Helmut Hummel voted on patch set 12 CR 0 V 0 01/20/16, 16:02
-
Nicole Hummel commented on patch set 12 01/20/16, 16:03
TestSetup.php:660sub folder missing? -
Markus Klein commented on patch set 12 01/20/16, 16:14
TestSetup.php:660ReplyNo! The subfolder is speciified inside the class -
Wouter Wolters voted on patch set 12 CR +1 01/20/16, 18:07
-
Wouter Wolters commented on patch set 12 01/20/16, 18:18
sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php:4749: $fileNameAndPath = PATH_site . 'typo3temp/phpunitJumpUrlTestFile with spaces & amps.txt'; sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php:4752: $fileName = substr($fileNameAndPath, strlen(PATH_site . 'typo3temp/')); sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php:4755: $result = $this->subject->filelink($fileName, array('path' => 'typo3temp/')); sysext/t3editor/Resources/Private/tsref.xml:494: <description><![CDATA[If set, the inline styles TYPO3 controls in the core are written to a file, typo3temp/stylesheet_[hashstring].css, and the header will only contain the link to the stylesheet. These lines of code still contain typo3temp without the new subdirectory -
Frank Nägler commented on patch set 12 CR +1 V +1 01/20/16, 21:12
looks good, but please check the lines Wouter found. -
Stefan Neufeind voted on patch set 12 CR +1 01/22/16, 19:07
-
Frank Nägler commented on patch set 12 CR -1 01/23/16, 11:13
on it, rebasing -
Frank Nägler uploaded patch set 13 01/23/16, 11:21
-
Frank Nägler commented on patch set 12 01/23/16, 11:22
only rebased and changed the lines, which was found by Wouter. -
Frank Nägler voted on patch set 13 CR +1 V +1 01/23/16, 11:22
-
Wouter Wolters voted on patch set 13 CR +1 01/23/16, 12:33
-
Benni Mack voted on patch set 13 CR +2 V +2 01/28/16, 06:15
-
Gerrit merged patch set 13 01/28/16, 06:35
-
Frans Saris commented on patch set 14 04/08/21, 15:24
AbstractOnlineMediaHelper.php:121UnresolvedFolder should be kept as `assets` as these files need te be public accessable