Review main Merged

46096[BUGFIX] Move all typo3temp files below typo3temp/var or assets

Helmut Hummel CR +2 V +2 Hard +221 −206 updated 04/08/21, 15:24

Commit message

The introduction of typo3temp/var and typo3temp/assets missed
essential changes.

* Files generated by tests
* Install Tool cleared wrong directory
* Some paths were only changed partially
* Some paths were changed to the public dir, but should in fact be private
* Some paths have been completely forgotten to be changed

Besides that, the introduction of new subfolder in typo3temp, we need
to allow arbitrary number of subfolders and remove the limitation of two
in GeneralUtility::writeFileToTypo3tempDir

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Frank Nägler +1
  • Verified V +2
    • Benni Mack +2
    • Frank Nägler +1

Issues 2

Files 44

Show 24 more files

Review log 49

Show 24 earlier messages
  1. Helmut Hummel uploaded patch set 1 01/19/16, 22:35

  2. Markus Klein commented on patch set 1 01/19/16, 22:52

    I'm not sure about those files generated by tests. Actually it shouldn't matter at all, where those are created, as those must be removed after the test execution anyway. Either by tearDown or the test itself.
  3. Markus Klein commented on patch set 1 01/19/16, 22:59

    GeneralUtility.php:2457

    must be adjusted too
  4. Markus Klein wrote 01/19/16, 23:00

    Patch set 2: Published edit on patch set 1.
  5. Markus Klein commented on patch set 1 01/19/16, 23:01

    GeneralUtility.php:2457 Reply

    Done
  6. Helmut Hummel commented on patch set 2 01/19/16, 23:15

    > I'm not sure about those files generated by tests. Well, we now differentiate between private (var) and public (assets) files in typo3temp. By definition, there must now be no file outside of these folders. Imho tests must stick to these standards as well. This change will also make it easieer for us to make these two locations configurable and made available through API
  7. Markus Klein voted on patch set 2 CR +1 01/19/16, 23:39

  8. Markus Klein uploaded patch set 3 01/20/16, 00:19

  9. Markus Klein commented on patch set 3 CR +1 V +1 01/20/16, 00:20

    Fixed the test for the deprecation log to also remove the directory created. var/tests/ is now empty for me after running all unittests. Only var/transient still contains some foo* files, which I did not find where those stem from.
  10. Georg Ringer voted on patch set 3 CR +1 01/20/16, 05:12

  11. Wouter Wolters voted on patch set 3 CR +1 01/20/16, 07:58

  12. Benni Mack uploaded patch set 4 01/20/16, 10:43

  13. Benni Mack commented on patch set 4 CR +1 V +1 01/20/16, 10:43

    Tests failed when I deleted typo3temp/ and ran the tests because some directories could be created. Changed the Bootstrap files of the tests.
  14. Nicole Hummel commented on patch set 3 01/20/16, 10:46

    UnitTestCase.php:86

    Should be removed as the test is only for typo3temp/var/

    renderedPage.html:19

    Should be "moved" to the css folder inside assets

    renderedPage.html:23

    Same here

    ExtensionCompatibilityTester.php:58

    Not sure if both files have to be accessible
  15. Nicole Hummel commented on patch set 4 CR -1 01/20/16, 10:48

    On it
  16. Markus Klein commented on patch set 4 CR -1 V -1 01/20/16, 12:29

    Regression fix for YoutubeHelper must be integrated
  17. Markus Klein uploaded patch set 5 01/20/16, 14:21

  18. Markus Klein commented on patch set 5 01/20/16, 14:27

    Nicole's comments are not yet tackled
  19. Helmut Hummel commented on patch set 3 01/20/16, 14:39

    ExtensionCompatibilityTester.php:58 Reply

    yes, they have to be accessible
  20. Helmut Hummel uploaded patch set 6 01/20/16, 14:39

  21. Helmut Hummel commented on patch set 6 01/20/16, 14:40

    @Markus: I changed the fix you pushed a bit. can you check if this is fine with you? Imho we do not need to check if the directory is there, as the install tool checks this already
  22. Helmut Hummel uploaded patch set 7 01/20/16, 14:45

  23. Markus Klein commented on patch set 7 01/20/16, 14:54

    > Imho we do not need to check if the directory is there, as the install tool checks this already This is not enough. There are many people out there which are used to truncate typo3temp. The install tool thingy is nice, but not sufficient and only called on initial setup.
  1. Markus Klein commented on patch set 7 01/20/16, 14:56

    AbstractOnlineMediaHelper.php:119

    PSR2

    PreviewProcessing.php:109

    This conflicts with my change in https://review.typo3.org/#/c/46110/1/typo3/sysext/core/Classes/Resource/OnlineMedia/Processing/PreviewProcessing.php This file must be cleaned up outside of this if, because it is there even if $temporaryFileNameForResizedThumb is not a file.
  2. Markus Klein commented on patch set 7 01/20/16, 14:58

    PreviewProcessing.php:109 Reply

    I removed my change from the other patch
  3. Markus Klein wrote 01/20/16, 14:59

    Patch set 8: Published edit on patch set 7.
  4. Helmut Hummel uploaded patch set 9 01/20/16, 15:10

  5. Helmut Hummel commented on patch set 9 01/20/16, 15:11

    fixed another regression from https://review.typo3.org/#/c/42385/ to be able to properly test the online media stuff :-/
  6. Helmut Hummel rebased onto patch set 10 01/20/16, 15:23

  7. Markus Klein uploaded patch set 11 01/20/16, 15:40

  8. Markus Klein uploaded patch set 12 01/20/16, 15:45

  9. Markus Klein voted on patch set 12 CR +1 V +1 01/20/16, 15:46

  10. Helmut Hummel voted on patch set 12 CR +1 V +1 01/20/16, 15:53

  11. Helmut Hummel voted on patch set 12 CR 0 V 0 01/20/16, 16:02

  12. Nicole Hummel commented on patch set 12 01/20/16, 16:03

    TestSetup.php:660

    sub folder missing?
  13. Markus Klein commented on patch set 12 01/20/16, 16:14

    TestSetup.php:660 Reply

    No! The subfolder is speciified inside the class
  14. Wouter Wolters voted on patch set 12 CR +1 01/20/16, 18:07

  15. Wouter Wolters commented on patch set 12 01/20/16, 18:18

    sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php:4749: $fileNameAndPath = PATH_site . 'typo3temp/phpunitJumpUrlTestFile with spaces & amps.txt'; sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php:4752: $fileName = substr($fileNameAndPath, strlen(PATH_site . 'typo3temp/')); sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php:4755: $result = $this->subject->filelink($fileName, array('path' => 'typo3temp/')); sysext/t3editor/Resources/Private/tsref.xml:494: <description><![CDATA[If set, the inline styles TYPO3 controls in the core are written to a file,  typo3temp/stylesheet_[hashstring].css, and the header will only contain the link to the stylesheet. These lines of code still contain typo3temp without the new subdirectory
  16. Frank Nägler commented on patch set 12 CR +1 V +1 01/20/16, 21:12

    looks good, but please check the lines Wouter found.
  17. Stefan Neufeind voted on patch set 12 CR +1 01/22/16, 19:07

  18. Frank Nägler commented on patch set 12 CR -1 01/23/16, 11:13

    on it, rebasing
  19. Frank Nägler uploaded patch set 13 01/23/16, 11:21

  20. Frank Nägler commented on patch set 12 01/23/16, 11:22

    only rebased and changed the lines, which was found by Wouter.
  21. Frank Nägler voted on patch set 13 CR +1 V +1 01/23/16, 11:22

  22. Wouter Wolters voted on patch set 13 CR +1 01/23/16, 12:33

  23. Benni Mack voted on patch set 13 CR +2 V +2 01/28/16, 06:15

  24. Gerrit merged patch set 13 01/28/16, 06:35

  25. Frans Saris commented on patch set 14 04/08/21, 15:24

    AbstractOnlineMediaHelper.php:121 Unresolved

    Folder should be kept as `assets` as these files need te be public accessable