46122[!!!][TASK] Remove RTE "modes" option in TCA
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Frank Nägler +1
-
Verified V +2
- Christian Kuhn +2
- Frank Nägler +1
Issues 1
Files 8
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+6 −10
- typo3/sysext/core/Classes/Migrations/TcaMigration.php+67 −0
- typo3/sysext/core/Configuration/TCA/sys_news.php+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-72856-RemovedRTEModesOption.rstnew+22 −0
- typo3/sysext/core/Tests/Unit/Migrations/TcaMigrationTest.php+358 −0
- typo3/sysext/css_styled_content/Configuration/TCA/Overrides/tt_content.php+2 −2
- typo3/sysext/fluid_styled_content/Configuration/TCA/Overrides/tt_content.php+1 −1
- typo3/sysext/rtehtmlarea/Classes/Form/Element/RichTextElement.php+4 −8
Review log 26
Show 1 earlier messages
-
Benni Mack uploaded patch set 1 01/20/16, 22:03
-
Benni Mack commented on patch set 1 01/20/16, 22:05
-1 breaking RsT missing, documentation also necessary -
Benni Mack wrote 01/21/16, 06:53
Patch set 2: Commit message was updated. -
Christian Kuhn voted on patch set 2 CR +1 01/21/16, 16:29
-
Benni Mack commented on patch set 2 CR -1 01/21/16, 16:31
-1 gotta do a RsT file still -
Benni Mack uploaded patch set 3 01/21/16, 16:36
-
Christian Kuhn commented on patch set 3 CR +1 01/21/16, 16:38
testing in a minute. -
Christian Kuhn voted on patch set 3 V +1 01/21/16, 16:44
-
Frank Nägler commented on patch set 3 CR -1 01/21/16, 20:11
We should add a TCAMigration, or not? -
Christian Kuhn commented on patch set 3 CR 0 V 0 01/21/16, 20:13
tca migration would be a good idea, yes. -
Christian Kuhn commented on patch set 3 01/22/16, 14:18
i'll have a look at the tca migration. -
Christian Kuhn voted on patch set 3 CR -1 01/22/16, 14:34
-
Christian Kuhn uploaded patch set 4 01/22/16, 16:03
-
Christian Kuhn commented on patch set 4 CR +1 V +1 01/22/16, 16:04
waiting for franks review -
Frank Nägler commented on patch set 4 CR -1 01/22/16, 16:38
found an issue in TCAMigration -
Frank Nägler uploaded patch set 5 01/22/16, 16:45
-
Frank Nägler voted on patch set 5 CR +1 V +1 01/22/16, 16:46
-
Christian Kuhn commented on patch set 5 01/22/16, 16:56
will retest. -
Christian Kuhn commented on patch set 5 CR -1 01/22/16, 17:08
still not ok - richtext[cut|copy|paste]:rte_transform[foo=bar] should become richtext[cut|copy|paste]:rte_transform after migration. -
Frank Nägler uploaded patch set 6 01/22/16, 17:13
-
Frank Nägler voted on patch set 6 CR +1 V +1 01/22/16, 17:13
-
Frank Nägler uploaded patch set 7 01/22/16, 17:17
-
Frank Nägler updated the commit message in patch set 8 01/22/16, 17:18
-
Frank Nägler voted on patch set 8 CR +1 V +1 01/22/16, 17:18
-
Christian Kuhn voted on patch set 8 CR +2 V +2 01/22/16, 17:19
-
Gerrit merged patch set 8 01/22/16, 17:19