Review main Merged Breaking

46122[!!!][TASK] Remove RTE "modes" option in TCA

Benni Mack CR +2 V +2 Hard +461 −22 updated 01/22/16, 17:19

Commit message

It's ts_css anyways all the time through the overruleMode
option, which should be used anyway for the time being (as this option
still exists).

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Frank Nägler +1
  • Verified V +2
    • Christian Kuhn +2
    • Frank Nägler +1

Issues 1

Files 8

Review log 26

Show 1 earlier messages
  1. Benni Mack uploaded patch set 1 01/20/16, 22:03

  1. Benni Mack commented on patch set 1 01/20/16, 22:05

    -1 breaking RsT missing, documentation also necessary
  2. Benni Mack wrote 01/21/16, 06:53

    Patch set 2: Commit message was updated.
  3. Christian Kuhn voted on patch set 2 CR +1 01/21/16, 16:29

  4. Benni Mack commented on patch set 2 CR -1 01/21/16, 16:31

    -1 gotta do a RsT file still
  5. Benni Mack uploaded patch set 3 01/21/16, 16:36

  6. Christian Kuhn commented on patch set 3 CR +1 01/21/16, 16:38

    testing in a minute.
  7. Christian Kuhn voted on patch set 3 V +1 01/21/16, 16:44

  8. Frank Nägler commented on patch set 3 CR -1 01/21/16, 20:11

    We should add a TCAMigration, or not?
  9. Christian Kuhn commented on patch set 3 CR 0 V 0 01/21/16, 20:13

    tca migration would be a good idea, yes.
  10. Christian Kuhn commented on patch set 3 01/22/16, 14:18

    i'll have a look at the tca migration.
  11. Christian Kuhn voted on patch set 3 CR -1 01/22/16, 14:34

  12. Christian Kuhn uploaded patch set 4 01/22/16, 16:03

  13. Christian Kuhn commented on patch set 4 CR +1 V +1 01/22/16, 16:04

    waiting for franks review
  14. Frank Nägler commented on patch set 4 CR -1 01/22/16, 16:38

    found an issue in TCAMigration
  15. Frank Nägler uploaded patch set 5 01/22/16, 16:45

  16. Frank Nägler voted on patch set 5 CR +1 V +1 01/22/16, 16:46

  17. Christian Kuhn commented on patch set 5 01/22/16, 16:56

    will retest.
  18. Christian Kuhn commented on patch set 5 CR -1 01/22/16, 17:08

    still not ok - richtext[cut|copy|paste]:rte_transform[foo=bar] should become richtext[cut|copy|paste]:rte_transform after migration.
  19. Frank Nägler uploaded patch set 6 01/22/16, 17:13

  20. Frank Nägler voted on patch set 6 CR +1 V +1 01/22/16, 17:13

  21. Frank Nägler uploaded patch set 7 01/22/16, 17:17

  22. Frank Nägler updated the commit message in patch set 8 01/22/16, 17:18

  23. Frank Nägler voted on patch set 8 CR +1 V +1 01/22/16, 17:18

  24. Christian Kuhn voted on patch set 8 CR +2 V +2 01/22/16, 17:19

  25. Gerrit merged patch set 8 01/22/16, 17:19