Review main Merged

46123[TASK] RTE: Store special TCA type configuration in local variable

Benni Mack CR +2 V +2 Easy +2 −9 updated 01/21/16, 10:29

Commit message

$this->rte_p is not used at all anymore, and can safely
be removed.

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Wouter Wolters +1
  • Verified V +2
    • Morton Jonuschat +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 6

  1. Benni Mack uploaded patch set 1 01/20/16, 22:05

  2. Benni Mack commented on patch set 1 CR -1 01/20/16, 22:05

    Rst file missing
  3. Benni Mack wrote 01/21/16, 06:46

    Patch set 2: Commit message was updated.
  4. Wouter Wolters commented on patch set 2 CR +1 V +1 01/21/16, 09:47

    Unused already since at least 4.5
  5. Morton Jonuschat voted on patch set 2 CR +2 V +2 01/21/16, 10:29

  6. Gerrit merged patch set 2 01/21/16, 10:29