46129[TASK] csConv: Enforce mbstring / iconv while converting
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 6
-
Benni Mack uploaded patch set 1 01/21/16, 07:08
-
Wouter Wolters voted on patch set 1 CR +1 01/22/16, 12:30
-
Christian Kuhn commented on patch set 1 02/01/16, 13:00
i don't fully understand the impact of this patch. is "the core does not use these functionalities" true? does this patch maybe need a breaking.rst? -
Benni Mack commented on patch set 1 02/11/16, 07:42
@lolli: The option useEntityForNoChar is never used within the core but circumvents TYPO3 to use either mbstring or iconv but instead using the homebrew TYPO3 internals to charset-convert strings. Basically, this one of the last step before we can actually completely remove the homebrewn TYPO3 stuff - so for one of the next patches, a breaking info with all relevant information would follow. If we remove this method parameter, I can provide a document for this, however I feel like the major breaking document should cover not just the breaking parts but also the new API calls, so we could add it there. -
Benni Mack commented on patch set 1 02/16/16, 11:47
Just found out this is still used in the core. So I'll abandon this patch for the time being. -
Benni Mack abandoned the change 02/16/16, 11:47