Review main Merged

4614[BUGFIX] Add DB structure update pre-processing hook in EM

Xavier Perseguers CR +2 V +2 Easy +31 −11 updated 06/03/13, 20:49

Commit message

Extension Manager lacks a way to perform actions prior to modifying the database
structure (create new tables or add additional fields in existing ones) when
installing an extension.

This would be very handy for DBAL to let user update mapping definition from within
TYPO3 without the need to first manually edit typo3conf/localconf.php.

This is a bugfix as the feature had been accepted for 4.5.0beta1 and was wrongly
removed during Extension Manager refactoring task. In fact, the interface is still
here but never used.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Björn Pedersen +1
    • Philipp Gampe +1
  • Verified V +2
    • Jigal van Hemert +2

Files 2

Review log 6

  1. Björn Pedersen commented on patch set 1 08/28/11, 13:11

    Looks good to me, but someone else must approve
  2. Xavier Perseguers commented on patch set 1 08/28/11, 13:11

    Have a look at DBAL, it's used there. Basically, you have to return some string in the hook to prevent the list of updated fields to be shown. If you don't return anything, then you may update the DB.
  3. Philipp Gampe commented on patch set 1 08/28/11, 13:11

    Looks good to me, but someone else must approve How to test this one ... Do you have any demo extension?
  4. Mr. Jenkins commented on patch set 1 08/28/11, 13:11

  5. Jigal van Hemert commented on patch set 1 V 0 08/28/11, 13:11

    by team member; Looks good to me, approved It was already reviewed and committed in 4.5; code is still exactly the same and hook is still called. Merged because of earlier approval.
  6. Jigal van Hemert merged patch set 1 08/28/11, 13:11