Review main Merged

46149[BUGFIX] EXT:form - Bring back missing default CSS styles

Ralf Zimmermann CR +2 V +2 Normal +205 −0 updated 01/22/16, 18:06

Commit message

Re-add the default CSS styles for EXT:form.
The default CSS styles have been removed by accident during the rewrite.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Björn Jacob +1
  • Verified V +2
    • Frank Nägler +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Björn Jacob +1

Issues 1

Files 1

Review log 11

  1. Ralf Zimmermann uploaded patch set 1 01/22/16, 10:06

  2. Björn Jacob wrote 01/22/16, 10:10

    Patch set 2: Commit message was updated.
  3. Markus Sommer commented on patch set 2 01/22/16, 12:36

    we realy need it?
  4. Björn Jacob commented on patch set 2 01/22/16, 14:33

    @Markus: Unfortunately, yes. It was always part of EXT:form and we didn't do any "deprecation". Neither was there a breaking .rst. So we have to bring it back since it was never noted to remove it.
  5. Björn Jacob commented on patch set 2 CR +1 V +1 01/22/16, 15:55

    Tested and compared with old state before rewrite.
  6. Stefan Neufeind commented on patch set 2 CR +1 V +1 01/22/16, 17:44

    Haven't actually tried on an installation, but compared the style-block against TYPO3 6.2 (which still had this block). Imho looks okay.
  7. Frank Nägler voted on patch set 2 CR +2 V +2 01/22/16, 18:05

  8. Christian Kuhn voted on patch set 2 CR +1 V +1 01/22/16, 18:05

  9. Christian Kuhn voted on patch set 2 CR +2 V +2 01/22/16, 18:06

  10. Gerrit merged patch set 2 01/22/16, 18:06

  11. Christian Kuhn commented on patch set 3 01/22/16, 18:06

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit df2790f4d215dcddfd0ecf23435c1ac90ac60001