46150[TASK] Add info about Apache version when using mod_filter
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Stefan Neufeind +1
-
Verified V +2
- Benni Mack +2
- Stefan Neufeind +1
Issues 1
Files 1
Review log 22
-
Eric Chavaillaz uploaded patch set 1 01/22/16, 10:59
-
Jérémie Roulin voted on patch set 1 CR +1 V +1 01/22/16, 11:12
-
Mathias Brodala commented on patch set 1 01/22/16, 11:14
Could you explain this change a bit more in detail in the commit message? -
Thomas Stenger voted on patch set 1 CR +1 01/22/16, 11:15
-
Mathias Schreiber wrote 01/22/16, 11:19
Patch set 2: Commit message was updated. -
Mathias Brodala commented on patch set 2 01/22/16, 11:46
Thanks Mathias. ;-) -
Markus Klein wrote 01/22/16, 12:03
Patch set 3: Commit message was updated. -
Markus Klein voted on patch set 3 CR +1 01/22/16, 12:03
-
Stefan Neufeind voted on patch set 3 CR +1 01/22/16, 15:23
-
Stefan Neufeind commented on patch set 3 01/22/16, 15:24
Is it safe to assume that mod_version is there? https://httpd.apache.org/docs/2.2/mod/mod_version.html -
Christian Kuhn voted on patch set 3 CR +1 01/22/16, 17:24
-
Jérémie Roulin commented on patch set 3 01/22/16, 23:49
More safe than considering Apache 2.3.7 or higher I think... -
Eric Chavaillaz commented on patch set 3 01/27/16, 15:05
One possibility is to make like HTML5 Boilerplate. They prevent with a comment like this : # Compress all output labeled with one of the following media types. # # (!) For Apache versions below version 2.3.7 you don't need to # enable `mod_filter` and can remove the `<IfModule mod_filter.c>` # and `</IfModule>` lines as `AddOutputFilterByType` is still in # the core directives. # # https://httpd.apache.org/docs/current/mod/mod_filter.html#addoutputfilterbytype -
Eric Chavaillaz uploaded patch set 4 01/27/16, 15:13
-
Benni Mack voted on patch set 4 CR +1 03/03/16, 17:19
-
Benni Mack commented on patch set 4 V +1 03/03/16, 17:22
Fine with the textual change. Tried it on apache 2.2.16 -
Benni Mack wrote 03/03/16, 19:18
Patch set 5: Commit message was updated. -
Benni Mack voted on patch set 5 CR +1 V +1 03/03/16, 19:18
-
Stefan Neufeind voted on patch set 5 CR +1 V +1 03/03/16, 19:23
-
Benni Mack voted on patch set 5 CR +2 V +2 03/03/16, 19:25
-
Gerrit merged patch set 5 03/03/16, 19:25
-
Benni Mack commented on patch set 6 03/03/16, 19:25
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit e1051f07d3cf412630bfe3e6ae4161e41a33611b