Review main Merged Breaking

46153[!!!][TASK] RteHtmlParser: Drop ts_reglinks transformation

Benni Mack CR +2 V +2 Normal +23 −42 updated 01/22/16, 17:52

Commit message

Converted <a> tag href attributes to absolute URLs when coming
from the DB towards the RTE and vice versa.

Transformation was never used, and can be removed.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Christian Kuhn +1
  • Verified V +2
    • Frank Nägler +2
    • Christian Kuhn +1

Issues 1

Files 2

Review log 8

  1. Benni Mack uploaded patch set 1 01/22/16, 12:35

  2. Benni Mack commented on patch set 1 01/22/16, 17:20

    rst and issue # still missing.
  3. Benni Mack uploaded patch set 2 01/22/16, 17:28

  4. Benni Mack wrote 01/22/16, 17:29

    Patch set 3: Commit message was updated.
  5. Christian Kuhn commented on patch set 3 01/22/16, 17:44

    RteHtmlParser.php:209

    second parameter is a pseudo boolean db/rte.

    RteHtmlParser.php:452

    that is then switched/cased again. so funny ^^
  6. Christian Kuhn voted on patch set 3 CR +1 V +1 01/22/16, 17:44

  7. Frank Nägler commented on patch set 3 CR +2 V +2 01/22/16, 17:52

    not used in TER and core, lets kick it :)
  8. Gerrit merged patch set 3 01/22/16, 17:52